ChangePropertyValue automatically coalesces properties

[wabrit]

Given a source YAML that looks like this:

quarkus:
  opentelemetry:
    enabled: true

and a recipe ChangePropertyKey("quarkus.opentelemetry.enabled", "quarkus.otel.enabled", ..)

the result is

quarkus:
  otel.enabled: true

This automatic coalescing of property names confuses Quarkus, which treats the new property as quarkus."otel.enabled" and doesn't match it to quarkus.otel.enabled.

The correct output in this case would be:

quarkus:
  otel:
    enabled: true

[wabrit]

The following simple failing test should demonstrate the issue:

class ChangePropertyKeyTest implements RewriteTest {

    @Test
    void simpleTest() {
        rewriteRun(
            spec -> spec.recipe(
                new ChangePropertyKey("quarkus.opentelemetry.enabled", "quarkus.otel.enabled",
                        null, "application.yml", null)
            ),
            yaml(
                """
                     quarkus:
                       foo:
                         bar: 1
                       opentelemetry:
                         enabled: true
                         
                    """,
                """
                    quarkus:
                       foo:
                         bar: 1
                       otel:
                         enabled: true
                         
                   """,
                spec -> spec.path("application.yml")
            )
        );
    }

[timtebeek]

Hmm; what version of OpenRewrite are you using? Since that "application.yml" causes a compiler error on the main branch.

[timtebeek]

Either way confirmed to be an issue also without that argument ; not clear yet what the fix should be unfortunately, so this goes onto the backlog.

[wabrit]

Hmm; what version of OpenRewrite are you using? Since that "application.yml" causes a compiler error on the main branch.

This is not latest major release; will check tomorrow when i have access to the code and record it here.

[timtebeek]

Previously seen on #1841