-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yaml - coalesce less #1841
Labels
bug
Something isn't working
Comments
nmck257
added a commit
to nmck257/rewrite
that referenced
this issue
May 31, 2022
…cing in DeleteProperty and YamlVisitor (openrewrite#1841)
nmck257
added a commit
to nmck257/rewrite
that referenced
this issue
Jun 1, 2022
…cing in DeleteProperty and YamlVisitor (openrewrite#1841)
nmck257
added a commit
to nmck257/rewrite
that referenced
this issue
Jun 1, 2022
…leting the first element in a document (openrewrite#1841)
pway99
pushed a commit
that referenced
this issue
Jun 1, 2022
pway99
added a commit
that referenced
this issue
Jun 2, 2022
pway99
added a commit
that referenced
this issue
Jun 21, 2022
PatrickViry
pushed a commit
that referenced
this issue
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed w/ @jkschneider on slack, consider a test case like this:
This case fails, as the actual value is this:
Few observations, ordered subjectively from most-to-least severe:
something.else
gets coalesced, though it was unrelated to the changex.y.z
gets coalesced, though the key it replaced was styled as non-coalescedx.y.z
gets relocated in the fileThese tend to conflict w/ this design intent: "OpenRewrite recipes make minimally invasive changes to your source code that honor the original formatting" (from the main page of the docs site).
This issue targets that first observation, and we'd like to try simply removing nested usages of
CoalesceProperties
from other recipes. This should get us closer to a target state, with low risk of functional changes.This could include:
ChangePropertyKey
DeleteProperty
MergeBootstrapYamlWithApplicationYaml
MigrateDatabaseCredentials
Future enhancements could include defining Styles for Yaml, to better-protect indent-vs-dot preferences.
The text was updated successfully, but these errors were encountered: