Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decreased yaml coalescing occurrences (#1841) #1860

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Decreased yaml coalescing occurrences (#1841) #1860

merged 2 commits into from
Jun 1, 2022

Conversation

nmck257
Copy link
Collaborator

@nmck257 nmck257 commented May 31, 2022

Removed coalescing from Yaml ChangePropertyKey, and deprecated coalescing in DeleteProperty and YamlVisitor (#1841)

Let me know if we want to adjust any details of the deprecation(s)

@pway99
Copy link
Contributor

pway99 commented Jun 1, 2022 •
edited
Loading

Thanks @nmck257,
This is a good change I would suggest also removing the org.openrewrite.yaml.ChangePropertyKey nonScalarMappingEntryExists(..) method which will no longer be used.

@nmck257 nmck257 force-pushed the feature/gh-1841 branch from be83c8a to 726b973 Compare June 1, 2022 11:27
@nmck257
Copy link
Collaborator Author

nmck257 commented Jun 1, 2022

Thanks @nmck257, This is a good change I would suggest also removing the org.openrewrite.yaml.ChangePropertyKey nonScalarMappingEntryExists(..) method which will no longer be used.

done!

@nmck257
Copy link
Collaborator Author

nmck257 commented Jun 1, 2022

heads up -- I also just slipped in another tiny fix from #1841 (extraneous newline at beginning of file)

@pway99 pway99 merged commit d801341 into openrewrite:main Jun 1, 2022
@nmck257 nmck257 deleted the feature/gh-1841 branch June 1, 2022 16:51
pway99 added a commit that referenced this pull request Jun 2, 2022
@pway99
Revert "Decreased yaml coalescing occurrences (#1841) (#1860)"
c2f7421 
This reverts commit d801341.
@pway99
Copy link
Contributor

pway99 commented Jun 2, 2022

Hi @nmck257,
Thanks for identifying #1873.
I reverted these changes from the 7.24.0 release, which will give us some time to fix everything up for 7.25.0.

pway99 added a commit that referenced this pull request Jun 21, 2022
@pway99
Revert "Revert "Decreased yaml coalescing occurrences (#1841) (#1860)""
a876c69 
This reverts commit c2f7421.
PatrickViry pushed a commit that referenced this pull request Jun 23, 2022
@pway99 @PatrickViry
Revert "Revert "Decreased yaml coalescing occurrences (#1841) (#1860)""
663a2fc 
This reverts commit c2f7421.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmck257 @pway99