Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.2] HSEARCH-4907 Follow-up: Clarify that hibernate.search.automatic_indexing.enable_dirty_check still works for now #3620

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Aug 3, 2023

https://hibernate.atlassian.net/browse/HSEARCH-4907

The previous wording was apparently confusing and made it seem like the property is already ignored; see quarkusio/quarkus-updates#47 (comment)

@yrodiere yrodiere requested a review from marko-bekhta August 3, 2023 05:50
Copy link
Member

@marko-bekhta marko-bekhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 this gives a better explanation 😃

@yrodiere yrodiere changed the title HSEARCH-4907 Follow-up: Clarify that hibernate.search.automatic_indexing.enable_dirty_check still works for now [6.2] HSEARCH-4907 Follow-up: Clarify that hibernate.search.automatic_indexing.enable_dirty_check still works for now Aug 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yrodiere yrodiere merged commit 15a8498 into hibernate:6.2 Aug 3, 2023
@yrodiere yrodiere deleted the HSEARCH-4907-6.2 branch November 29, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants