Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.2] HSEARCH-4907 Follow-up: Clarify that hibernate.search.automatic_indexing.enable_dirty_check still works for now #3620

Merged
merged 1 commit into from
Aug 3, 2023
Merged

[6.2] HSEARCH-4907 Follow-up: Clarify that hibernate.search.automatic_indexing.enable_dirty_check still works for now #3620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion documentation/src/main/asciidoc/migration/index.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ Additionally, some configuration properties have been deprecated:
* `hibernate.search.automatic_indexing.synchronization.strategy` is now deprecated in favor of `hibernate.search.indexing.plan.synchronization.strategy`.
* `hibernate.search.automatic_indexing.enabled` is now deprecated in favor of `hibernate.search.indexing.listeners.enabled`.
* `hibernate.search.automatic_indexing.enable_dirty_check` is now deprecated with no alternative to replace it.
A dirty check will always be performed when considering triggering the reindexing.
After its removal in a future version, a dirty check will always be performed when considering whether to trigger reindexing.

[[api]]
== API changes
Expand Down
3 changes: 2 additions & 1 deletion ...te/search/integrationtest/mapper/orm/automaticindexing/AutomaticIndexingDirtyCheckIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ public class AutomaticIndexingDirtyCheckIT {
+ "'hibernate.search.automatic_indexing.enable_dirty_check' is deprecated. "
+ "This setting will be removed in a future version. "
+ "There will be no alternative provided to replace it. "
+ "A dirty check will always be performed when considering triggering the reindexing.";
+ "After the removal of this property in a future version, "
+ "a dirty check will always be performed when considering whether to trigger reindexing.";

@Rule
public BackendMock backendMock = new BackendMock();
Expand Down
12 changes: 8 additions & 4 deletions mapper/orm/src/main/java/org/hibernate/search/mapper/orm/cfg/HibernateOrmMapperSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ private HibernateOrmMapperSettings() {
* Defaults to {@link Defaults#AUTOMATIC_INDEXING_ENABLE_DIRTY_CHECK}.
*
* @deprecated This setting will be removed in a future version. There will be no alternative provided to replace it.
* A dirty check will always be performed when considering triggering the reindexing.
* After the removal of this property in a future version,
* a dirty check will always be performed when considering whether to trigger reindexing.
*/
@Deprecated
public static final String AUTOMATIC_INDEXING_ENABLE_DIRTY_CHECK = PREFIX + Radicals.AUTOMATIC_INDEXING_ENABLE_DIRTY_CHECK;
Expand Down Expand Up @@ -260,7 +261,8 @@ private Radicals() {
AUTOMATIC_INDEXING_PREFIX + AutomaticIndexingRadicals.SYNCHRONIZATION_STRATEGY;
/**
* @deprecated This setting will be removed in a future version. There will be no alternative provided to replace it.
* A dirty check will always be performed when considering triggering the reindexing.
* After the removal of this property in a future version,
* a dirty check will always be performed when considering whether to trigger reindexing.
*/
@Deprecated
public static final String AUTOMATIC_INDEXING_ENABLE_DIRTY_CHECK =
Expand Down Expand Up @@ -310,7 +312,8 @@ private AutomaticIndexingRadicals() {
public static final String SYNCHRONIZATION_STRATEGY = "synchronization.strategy";
/**
* @deprecated This setting will be removed in a future version. There will be no alternative provided to replace it.
* A dirty check will always be performed when considering triggering the reindexing.
* After the removal of this property in a future version,
* a dirty check will always be performed when considering whether to trigger reindexing.
*/
@Deprecated
public static final String ENABLE_DIRTY_CHECK = "enable_dirty_check";
Expand Down Expand Up @@ -381,7 +384,8 @@ private Defaults() {
"write-sync" );
/**
* @deprecated This setting will be removed in a future version. There will be no alternative provided to replace it.
* A dirty check will always be performed when considering triggering the reindexing.
* After the removal of this property in a future version,
* a dirty check will always be performed when considering whether to trigger reindexing.
*/
@Deprecated
public static final boolean AUTOMATIC_INDEXING_ENABLE_DIRTY_CHECK = true;
Expand Down
3 changes: 2 additions & 1 deletion mapper/orm/src/main/java/org/hibernate/search/mapper/orm/logging/impl/Log.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,8 @@ void failedToResolveStateRepresentation(String path, @FormatWith(EventContextFor
@Message(id = ID_OFFSET + 125, value = "Configuration property '%1$s' is deprecated. "
+ "This setting will be removed in a future version. "
+ "There will be no alternative provided to replace it. "
+ "A dirty check will always be performed when considering triggering the reindexing.")
+ "After the removal of this property in a future version, "
+ "a dirty check will always be performed when considering whether to trigger reindexing.")
void automaticIndexingEnableDirtyCheckIsDeprecated(String deprecatedProperty);

@Message(id = ID_OFFSET + 126,
Expand Down