Enable tests after fixing quarkus-qe/quarkus-test-framework#584. #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalvavrik
previously requested changes
Jul 29, 2023
There was a problem hiding this comment.
@jedla97 thank you for changes.
PR description says it enables tests, but it does not (please see CI). Tests are disabled on Windows as TestContainers don't support Windows containers and we don't have compatible docker agent ready.
Only ReactiveRestClientProxyIT actually needs Docker, please drop Maven profile and disable this one test on Windows so that we actually can test your changes when FW is released and bumped. Thank you
jedla97
force-pushed
the
remove-suspended-tests
branch
from
d78a58f to
b34d994
Compare
|
@jedla97 please rebase your PR onto main as TS is now using 1.3.0.Beta23. |
…isable only ReactiveRestClientProxyIT.
jedla97
force-pushed
the
remove-suspended-tests
branch
from
b34d994 to
45f5087
Compare
jedla97
changed the title
|
@michalvavrik PR rebased and test seem ok. The enabled test are running on windows now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi, this PR remove the disabled annotation on tests affected by by quarkus-qe/quarkus-test-framework#584.
It can be merged after the quarkus-qe/quarkus-test-framework#842 is merged and new version of framework is released and updated.
Please select the relevant options.
run testsphrase in comment)Checklist: