Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix properties not escape " on windows #842

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Jul 26, 2023

Summary

Hi, this PR resolve #584 which not escaped char "caused fail some tests on windows machine.

Testing it on windows with tests from Quarkus TS (with LargeFileHandlingIT and ReactiveRestClientIT tests). After this change tests are passing without problem on Windows and Linux.

Before:

[INFO] Running io.quarkus.ts.http.restclient.reactive.LargeFileHandlingIT
08:56:18,857 INFO  [app] Initialize service (Quarkus JVM mode)
08:56:18,889 INFO  Running command: java -Dquarkus.vertx.warning-exception-time=5s -Dquarkus.rest-client."io.quarkus.ts.http.restclient.reactive.ResourceAndSubResourcesClient".url=http://localhost:${quarkus.http.port} -Dquarkus.rest-client.logging.scope=request-response -Dclient.filepath=C:\Users\RUNNER~1\AppData\Local\Temp\large_files11198165765889963790 -Dquarkus.rest-client.read-timeout=120000 -Dquarkus.rest-client."io.quarkus.ts.http.restclient.reactive.files.FileClient".url=http://localhost:${quarkus.http.port} -Dquarkus.http.limits.max-body-size=3G -Dquarkus.log.category."org.jboss.resteasy.reactive.client.logging".level=DEBUG -Dquarkus.rest-client."io.quarkus.ts.http.restclient.reactive.BookClient".url=http://localhost:${quarkus.http.port} -Dquarkus.rest-client."io.quarkus.ts.http.restclient.reactive.BookClient.AuthorClient".url=http://localhost:${quarkus.http.port} -Dquarkus.rest-client."io.quarkus.ts.http.restclient.reactive.json.JsonRestInterface".url=http://localhost:${quarkus.http.port} -Dquarkus.log.console.format=%d{HH:mm:ss,SSS} %s%e%n -Dquarkus.http.port=1101 -jar D:\a\quarkus-test-suite\quarkus-test-suite\http\rest-client-reactive\target\quarkus-app\quarkus-run.jar

...
08:56:34,974 INFO  [app] 08:56:33,895 HTTP Request to /file-client/hash failed, error id: 12b0bc13-414c-40a9-9fdf-cb722a2d0aff-1: java.lang.IllegalArgumentException: Unable to determine the proper baseUrl/baseUri. Consider registering using @RegisterRestClient(baseUri="someuri"), @RegisterRestClient(configKey="orkey"), or by adding 'quarkus.rest-client."io.quarkus.ts.http.restclient.reactive.files.FileClient".url' or 'quarkus.rest-client."io.quarkus.ts.http.restclient.reactive.files.FileClient".uri' to your Quarkus configuration
...

Error:  Tests run: 9, Failures: 6, Errors: 0, Skipped: 1, Time elapsed: 218.824 s <<< FAILURE! - in io.quarkus.ts.http.restclient.reactive.LargeFileHandlingIT

After fix:

[INFO] Running io.quarkus.ts.http.restclient.reactive.LargeFileHandlingIT
08:34:22,741 INFO  [app] Initialize service (Quarkus JVM mode)
08:34:22,772 INFO  Running command: java -Dquarkus.vertx.warning-exception-time=5s -Dquarkus.rest-client.\"io.quarkus.ts.http.restclient.reactive.ResourceAndSubResourcesClient\".url=http://localhost:${quarkus.http.port} -Dquarkus.rest-client.logging.scope=request-response -Dclient.filepath=C:\Users\RUNNER~1\AppData\Local\Temp\large_files5316569886669347137 -Dquarkus.rest-client.read-timeout=120000 -Dquarkus.rest-client.\"io.quarkus.ts.http.restclient.reactive.files.FileClient\".url=http://localhost:${quarkus.http.port} -Dquarkus.http.limits.max-body-size=3G -Dquarkus.log.category.\"org.jboss.resteasy.reactive.client.logging\".level=DEBUG -Dquarkus.rest-client.\"io.quarkus.ts.http.restclient.reactive.BookClient\".url=http://localhost:${quarkus.http.port} -Dquarkus.rest-client.\"io.quarkus.ts.http.restclient.reactive.BookClient.AuthorClient\".url=http://localhost:${quarkus.http.port} -Dquarkus.rest-client.\"io.quarkus.ts.http.restclient.reactive.json.JsonRestInterface\".url=http://localhost:${quarkus.http.port} -Dquarkus.log.console.format=%d{HH:mm:ss,SSS} %s%e%n -Dquarkus.http.port=1101 -jar D:\a\quarkus-test-suite\quarkus-test-suite\http\rest-client-reactive\target\quarkus-app\quarkus-run.jar

...
Warning:  Tests run: 9, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 425.528 s - in io.quarkus.ts.http.restclient.reactive.LargeFileHandlingIT

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mjurc
Copy link
Member

mjurc commented Jul 26, 2023

run tests

@mjurc mjurc self-requested a review July 26, 2023 13:55
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's make sure this doesn't break anything from CI

@mjurc
Copy link
Member

mjurc commented Jul 26, 2023

Failures unrelated; merging

@mjurc mjurc merged commit 859f449 into quarkus-qe:main Jul 26, 2023
@michalvavrik michalvavrik mentioned this pull request Aug 4, 2023
11 tasks
@jedla97 jedla97 deleted the fix-584 branch April 25, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Framework doesn't handle quoted properties properly
2 participants