Enable tests after fixing quarkus-qe/quarkus-test-framework#584 and d…

…isable only ReactiveRestClientProxyIT.
quarkus-qe · Aug 1, 2023 · b34d994 · b34d994
1 parent 5cc2206
commit b34d994
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 39 deletions.
diff --git a/http/rest-client-reactive/pom.xml b/http/rest-client-reactive/pom.xml
@@ -32,31 +32,4 @@
             <artifactId>commons-lang3</artifactId>
         </dependency>
     </dependencies>
-    <profiles>
-        <!-- Skipped on Windows as does not support Linux Containers / Testcontainers -->
-        <profile>
-            <id>skip-tests-on-windows</id>
-            <activation>
-                <os>
-                    <family>windows</family>
-                </os>
-            </activation>
-            <build>
-                <plugins>
-                    <plugin>
-                        <artifactId>maven-surefire-plugin</artifactId>
-                        <configuration>
-                            <skip>true</skip>
-                        </configuration>
-                    </plugin>
-                    <plugin>
-                        <artifactId>maven-failsafe-plugin</artifactId>
-                        <configuration>
-                            <skip>true</skip>
-                        </configuration>
-                    </plugin>
-                </plugins>
-            </build>
-        </profile>
-    </profiles>
 </project>
diff --git a/...nt-reactive/src/test/java/io/quarkus/ts/http/restclient/reactive/LargeFileHandlingIT.java b/...nt-reactive/src/test/java/io/quarkus/ts/http/restclient/reactive/LargeFileHandlingIT.java
@@ -18,8 +18,6 @@
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.condition.DisabledOnOs;
-import org.junit.jupiter.api.condition.OS;
 
 import io.quarkus.test.bootstrap.RestService;
 import io.quarkus.test.scenarios.QuarkusScenario;
@@ -58,7 +56,6 @@ public LargeFileHandlingIT() {
     }
 
     @Test
-    @DisabledOnOs(value = OS.WINDOWS, disabledReason = "https://github.com/quarkus-qe/quarkus-test-framework/issues/584")
     public void validateClientResponse() {
         Response original = app.given().get("/file/hash");
         Response wrapped = app.given().get("/file-client/hash");
@@ -83,7 +80,6 @@ public void downloadDirectly() throws IOException {
     }
 
     @Test
-    @DisabledOnOs(value = OS.WINDOWS, disabledReason = "https://github.com/quarkus-qe/quarkus-test-framework/issues/584")
     public void downloadThroughClient() {
         Response hashSum = app.given().get("/file/hash");
         assertEquals(HttpStatus.SC_OK, hashSum.statusCode());
@@ -97,7 +93,6 @@ public void downloadThroughClient() {
     }
 
     @Test
-    @DisabledOnOs(value = OS.WINDOWS, disabledReason = "https://github.com/quarkus-qe/quarkus-test-framework/issues/584")
     public void downloadMultipart() {
         Response hashSum = app.given().get("/file/hash");
         assertEquals(HttpStatus.SC_OK, hashSum.statusCode());
@@ -139,7 +134,6 @@ public void uploadFile() {
     }
 
     @Test
-    @DisabledOnOs(value = OS.WINDOWS, disabledReason = "https://github.com/quarkus-qe/quarkus-test-framework/issues/584")
     public void uploadFileThroughClient() {
         Response hashSum = app.given().get("/file-client/client-hash");
         assertEquals(HttpStatus.SC_OK, hashSum.statusCode());
@@ -153,7 +147,6 @@ public void uploadFileThroughClient() {
     }
 
     @Test
-    @DisabledOnOs(value = OS.WINDOWS, disabledReason = "https://github.com/quarkus-qe/quarkus-test-framework/issues/584")
     public void uploadMultipart() {
         Response hashSum = app.given().get("/file-client/client-hash");
         assertEquals(HttpStatus.SC_OK, hashSum.statusCode());
@@ -167,7 +160,6 @@ public void uploadMultipart() {
     }
 
     @Test
-    @DisabledOnOs(value = OS.WINDOWS, disabledReason = "https://github.com/quarkus-qe/quarkus-test-framework/issues/584")
     public void failOnMalformedMultipart() {
         Response download = app.given().get("/file-client/download-broken-multipart");
         assertEquals(HttpStatus.SC_INTERNAL_SERVER_ERROR, download.statusCode());

diff --git a/...t-reactive/src/test/java/io/quarkus/ts/http/restclient/reactive/ReactiveRestClientIT.java b/...t-reactive/src/test/java/io/quarkus/ts/http/restclient/reactive/ReactiveRestClientIT.java
@@ -10,8 +10,6 @@
 import org.apache.http.HttpStatus;
 import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.condition.DisabledOnOs;
-import org.junit.jupiter.api.condition.OS;
 
 import io.quarkus.test.bootstrap.Protocol;
 import io.quarkus.test.bootstrap.RestService;
@@ -30,7 +28,6 @@ public class ReactiveRestClientIT {
     static RestService app = new RestService().withProperties("modern.properties");
 
     @Test
-    @DisabledOnOs(value = OS.WINDOWS, disabledReason = "https://github.com/quarkus-qe/quarkus-test-framework/issues/584")
     public void shouldGetBookFromRestClientJson() {
         Response response = app.given().with().pathParam("id", "123")
                 .get("/client/book/{id}/json");
@@ -40,7 +37,6 @@ public void shouldGetBookFromRestClientJson() {
 
     @Tag("QUARKUS-1568")
     @Test
-    @DisabledOnOs(value = OS.WINDOWS, disabledReason = "https://github.com/quarkus-qe/quarkus-test-framework/issues/584")
     public void supportPathParamFromBeanParam() {
         Response response = app.given().with().pathParam("id", "123")
                 .get("/client/book/{id}/jsonByBeanParam");

diff --git a/...ctive/src/test/java/io/quarkus/ts/http/restclient/reactive/ReactiveRestClientProxyIT.java b/...ctive/src/test/java/io/quarkus/ts/http/restclient/reactive/ReactiveRestClientProxyIT.java
@@ -5,6 +5,8 @@
 import org.apache.http.HttpStatus;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.condition.DisabledOnOs;
+import org.junit.jupiter.api.condition.OS;
 
 import io.quarkus.test.bootstrap.RestService;
 import io.quarkus.test.scenarios.QuarkusScenario;
@@ -13,6 +15,7 @@
 import io.restassured.response.Response;
 
 @QuarkusScenario
+@DisabledOnOs(value = OS.WINDOWS, disabledReason = "Windows does not support Linux Containers / Testcontainers")
 public class ReactiveRestClientProxyIT {
     private static final String USER = "proxyuser";
     private static final String PASSWORD = "proxypassword";