Enable Hibernate Reactive tests for PostgreSQL, MariaDB and MySQL #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run tests |
|
Debugging OC failures. |
michalvavrik
force-pushed
the
feature/enable-hibernate-reactive-modules
branch
from
4b6c1cb to
8519d14
Compare
|
Opened issue as I wasted loads of time on this quarkusio/quarkus#32040. |
michalvavrik
changed the title
michalvavrik
force-pushed
the
feature/enable-hibernate-reactive-modules
branch
2 times, most recently
from
85c194c to
7f74778
Compare
michalvavrik
changed the title
|
run tests |
fedinskiy
approved these changes
Mar 24, 2023
|
I'll check native (and don't do anything till it's fixed) :-/ |
|
It's like never ending story.... |
|
It is! You can drop |
|
As for OpenShift failures, they all succeeded when run from my workstation (in terms of Hibernate Reactive modules), so there must be some difference when run from CI, I am on it. |
|
Created upstream issue for native failure: quarkusio/quarkus#32114 |
michalvavrik
force-pushed
the
feature/enable-hibernate-reactive-modules
branch
from
7f74778 to
f0a68ae
Compare
|
run tests |
|
There is one OpenShift JVM mode failure now - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
quarkusio/quarkus#31454 is merged, so we should be testing Hibernate Reactive for PostgreSQL, MariaDB and MySQL, while MsSQL and Oracle will work in next release quarkusio/quarkus#32102 (comment).
Changes:
DROP TABLEdidn't work and logged constraint violation (correct behavior)AuthorandBookto unidirectional@OneToMany. Previously we had some hybrid between unidirectional and bidirectional mapping that doesn't work anymore due to casting exception. In my understanding that's absolutely correct behavior - for bidirectional mapping you need entity on the other side, while we were using primitive type without@ManyToOnebut still set@OneToMany#mappedBy.MariaDB102DialecttoMariaDBDialectas former is not supported anymore and we don't use legacy database@WithSessiondue to recent changes in Panache Hibernate reactive panache refactoring quarkusio/quarkus#29761,@WithSessiondoes not supportMulti@ReactiveTransactionalhas been marked for removal, so I changed one of 2 usages in Spring Web Reactive ti@WithTransactionin order to have tested preferred wayPlease select the relevant options.
run testsphrase in comment)Checklist: