Hibernate reactive panache refactoring

[mkouba]

• do not store the current reactive session in the CDI request context but instead in the vertx duplicated context
• do not offload execution of a panache entity method on the current vertx context but instead validate that the method is executed on the vetx duplicated context
• introduce @WithSession, @WithSessionOnDemand and @WithTransaction bindings and interceptors
• deprecate ReactiveTransactional (WithTransaction should be used instead)
• ReactiveTransactionalInterceptor can only be used for methods that return Uni; this is validated at build time
• if resteasy-reactive is present then automatically add the @WithSessionOnDemand binding to all resource methods on classes that use a panache entity
• remove the quarkus-integration-test-hibernate-reactive-panache-blocking module
• quarkus-test-vertx - run the test method on a duplicated vertx context even if the @RunOnVertxContext is not present but the @TestReactiveTransaction is
• update integration-tests/hibernate-reactive-panache-kotlin
• update documentation

[FroMage]

Sorry for the late review :(

[mkouba]

Sorry for the late review :(

No problem, better late than never! ;-)

[FroMage]

LGTM.
Do you think there's any need for a @WithoutSession to disable the automatic @WithSessionIfNeeded? I don't think so.
In Renarde, I automatically add the @Transactional annotation to POST/PUT/DELETE methods, but I've often wondered if I should add a @NoTransaction annotation to disable this. Perhaps we need a @WithoutTransaction in HR/Panache, so that I can avoid auto-adding @WithTransaction when I integrate HR in Renarde?

[mkouba]

Do you think there's any need for a @WithoutSession to disable the automatic @WithSessionIfNeeded? I don't think so.

I agree.

In Renarde, I automatically add the @Transactional annotation to POST/PUT/DELETE methods, but I've often wondered if I should add a @NoTransaction annotation to disable this. Perhaps we need a @WithoutTransaction in HR/Panache, so that I can avoid auto-adding @WithTransaction when I integrate HR in Renarde?

What would be the point of @WithoutTransaction in the context of HR/Panache? I mean this is the default, unless you specify @WithTransaction so I don't really understand...

[FroMage]

Because I automatically add the @Transactional on every method :) So this would be a way to turn it off. It's not needed for lazy sessions because they're inexpensive and you only pay when used. But for transactions, that's probably expensive if not used, because HR transactions are not lazy like ORM transactions.

[mkouba]

Well, I think that such an annotation should go into Renarde then...

[FroMage]

Yes, that's very possible.

[sberyozkin]

Hi @mkouba, not sure it is relevant, I was trying https://github.com/quarkusio/quarkus-quickstarts/tree/main/kafka-panache-reactive-quickstart (I composing a security demo from various quickstarts), and I've noticed, I believe, that if quarkus-reactive-pg-client is not included here, https://github.com/quarkusio/quarkus-quickstarts/blob/main/kafka-panache-reactive-quickstart/pom.xml#L41, then this code, https://github.com/quarkusio/quarkus-quickstarts/blob/main/kafka-panache-reactive-quickstart/src/main/java/org/acme/panache/PriceStorage.java#L18, returns NPE.

If it is indeed the case (confirmed) then may be it can make sense to have quarkus-hibernate-panache-reactive directly depending on quarkus-reactive-pg-client ? In devmode, it would be nice to be able to only add quarkus-hibernate-panache-reactive to the pom, without having to add quarkus-reactive-pg-client, if it is required anyway...

Sorry if it is off-topic

[mkouba]

If it is indeed the case (confirmed) then may be it can make sense to have quarkus-hibernate-panache-reactive directly depending on quarkus-reactive-pg-client ? In devmode, it would be nice to be able to only add quarkus-hibernate-panache-reactive to the pom, without having to add quarkus-reactive-pg-client, if it is required anyway...

I don't think it's required. I mean you just need to add an reactive SQL client extension like for any Hibernate Reactive application.

[sberyozkin]

But if without it NPE is returned then may be it is required ?

[sberyozkin]

Sorry, see what you mean, there are a few client types, may be a better error message can be returned like please add a client, etc

[mkouba]

Sorry, see what you mean, there are a few client types, may be a better error message can be returned like please add a client, etc

I wonder if the NPE is thrown for vanilla Hibernate Reactive as well?

[sberyozkin]

I wonder if the NPE is thrown for vanilla Hibernate Reactive as well?

I haven't tried, sorry, I just looked at Hibernate Panache Reactive as the code looks simpler which is what I'll need to for the introduction demo

[quarkus-bot]

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

[mkouba]

The CI is green now!

FTR all Multi<T> stream() methods were removed.

@FroMage @DavideD @Sanne I'm going to merge this pull reuqest but I do expect some follow-ups based on potential feedback.

[DavideD]

Thanks @mkouba

[FroMage]

+1