-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hibernate Reactive 2.0.0.Alpha2 & re-enabling all HR modules #31454
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
aaf4e12
to
9ebbd55
Compare
Rebased & upgraded to Hibernate ORM 6.2.0.CR3 |
9ebbd55
to
3292cfc
Compare
Based now on Hibernate Reactive |
684f1b2
to
51c2ed1
Compare
This comment has been minimized.
This comment has been minimized.
51c2ed1
to
508e692
Compare
Rebasing to test with the other two ORM related PRs |
Status update: we seem to have a setback in the Panache integration tests; I didn't have that many failures just 3 days ago. Unfortunately the Panache ITs are of the old style: runs a series of operations and if all of them succeeds, returns "OK" - we only test for OK to be returned. On top of this, they are chained & ordered, potentially leading to cascading failures of assumptions; not great for evaluating in short time what's going on. I didn't have time to check that so there's now many more Panache tests disabled - this to allow getting a picture of other components by CI, while we try having a better look at Panache tests. cc/ @FroMage perhaps you can help dissecting / sorting them? It's very likely that the problem is in HR, but I suspect there's many tests failing for the same underlying issue - would be great to figure that out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #31242, I listed what should be reverted and I would prefer we don't revert fd56088 .
It wasn't in the list for a good reason as it reduces our dependency to the Hibernate Reactive modules in the codebase. It's a small step forward but still.
I also added a question regarding the sequences but I will let @yrodiere confirm if it's an issue or not.
...nsions/panache/hibernate-reactive-rest-data-panache/deployment/src/test/resources/import.sql
Show resolved
Hide resolved
If we have significant issues that are remaining, I would advise to release Alpha 5 tomorrow without Hibernate Reactive and release an Alpha6 next week when things are more stable. I will let you decide what you want to do. To be in Alpha5, things have to be merged in |
508e692
to
6240f14
Compare
…est-data-panache : OpenApiIntegrationTest
… consistent configuration with other modules
Use uni.invoke() instead of subscribe because that would cause a double subscription, so running the actions twice, in HR
cfe3854
to
2f2caf4
Compare
Failing Jobs - Building 2f2caf4
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #📦 integration-tests/gradle✖
✖
✖
✖
⚙️ JVM Tests - JDK 17 Windows #- Failing: extensions/grpc/deployment extensions/resteasy-classic/rest-client/runtime extensions/smallrye-reactive-messaging-amqp/deployment
! Skipped: extensions/amazon-lambda-http/deployment extensions/amazon-lambda-http/http-event-server extensions/amazon-lambda-rest/deployment and 122 more 📦 extensions/grpc/deployment✖
📦 extensions/resteasy-classic/rest-client/runtime✖
📦 extensions/smallrye-reactive-messaging-amqp/deployment✖
✖
✖
✖
✖
|
It's looking good - I'll merge this and tracked follow-up work in #31974 |
Putting this here as it's almost useable.
Versions:
6.2
branch of ORM, but we don't want to wait for another ORM core tag.Known working:
Known problems:
Hibernate Reactive REST data with Panache
integration tests trigger some of the not-yet-supported queries (it appears to be a lazy initialization load triggered during query result processing)Unknown:
There's a number of other modules depending on Hibernate Reactive which I'm unable to test because of miscellaneous build & container issues. e.g. WebAuthn, Kafka, gRPC, OpenTelemetry Reactive, Smallrye Reactive Messaging.
Also, we don't have Oracle / Hibernate Reactive integration tests apparently.
cc/ @geoand @gsmet @yrodiere @cescoffier
Fixes #31242