Adds support for XD84 Pro #9750

katawajojo · 2020-07-18T11:30:03Z

Adds QMK support for KPRepublic's XD84 Pro PCB.
Includes ANSI, ISO, and VIA (ANSI layout only currently) Support.

Description

Adds support for KPRepublic's XD84 Pro PCB.
The PCB's silkscreen refers to this board as "XD84 v2.0"

I've also created a VIA pull request as well.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Adds QMK support for KPRepublic's XD84 Pro PCB. Includes ANSI, ISO, and VIA (ANSI layout only currently) Support.

fixed make code snippet

keyboards/xd84pro/keymaps/via/rules.mk

keyboards/xd84pro/readme.md

keyboards/xd84pro/rules.mk

keyboards/xd84pro/xd84pro.c

katawajojo · 2020-07-18T12:55:53Z

Thanks for the suggestions, I’ll take care of them when I wake up in the morning.

sigprof · 2020-07-18T20:17:11Z

You should make a LAYOUT_all macro (and the corresponding entry in info.json) which includes all possible key positions. At the moment there are two missing parts:

According to the vendor documentation (1, 2), this PCB supports splitting the 2U Backspace key into 2×1U keys. You should figure out the matrix positions of those keys (one of them probably occupies some of remaining positions on the last row, the other is most likely the same as the 2U Backspace) and add them to LAYOUT_all.
This PCB, like other XD* PCBs, not just has three distinct matrix positions for the ANSI backslash, ISO NUHS and Enter, but actually supports installing 1U+1.25U keys in the place normally occupied by the 2.25U ANSI Enter. Again, you should check how those matrix positions are connected (although in this case the fact that the 1.25U part of ANSI Enter is connected in parallel to the normal ANSI Enter pads is even visible on this shop photo), and add all those 3 keys to LAYOUT_all.

The rest of LAYOUT_all should be the same as LAYOUT_75_iso (so that the NUBS key would be present).

After adding this LAYOUT_all macro you should use it in the via keymap to make a layout which could work for both ISO and ANSI out of the box (this should be possible on this PCB, even the ANSI backslash and ISO NUHS could be made distinct). For the split Backspace you could just assign KC_BSPC to both halves of the 2U Backspace.

stale · 2020-09-02T00:14:15Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

Popkornium18 · 2020-09-04T14:40:52Z

@katawajojo are you still planning to make the requested changes? If not I might give it a go, since I picked up this board thinking it was supported 🤦

katawajojo · 2020-09-05T01:48:18Z

Sorry! I've been working on these changes, but I've also been hella busy with school coming up and work. Give me like, a day or two to finish these up, and update the pull.

katawajojo · 2020-09-05T10:06:54Z

Okay, so I'm going to remove the VIA stuff for now, as I need to do some research on doing that all properly. I have every layout mapped and ready, I'm just not sure how to go about properly creating the LAYOUT_all macro.

Side note: this keyboard has a backlighting issue that's resolved with the pull request #9575. Applying the code from this pull request fixes the flickering backlight.

Attached is the matrix layout for all keys, and all supported configurations of the board.
matrix+layouts.txt

Removing VIA for the time being. I'll need to sit and figure this one out.

Popkornium18 · 2020-09-05T16:10:32Z

Side note: this keyboard has a backlighting issue that's resolved with the pull request #9575. Applying the code from this pull request fixes the flickering backlight.

It doesn't fix the problem for me 🤔

katawajojo · 2020-09-05T22:03:15Z

Side note: this keyboard has a backlighting issue that's resolved with the pull request #9575. Applying the code from this pull request fixes the flickering backlight.

It doesn't fix the problem for me 🤔

Odd, as this fixed the flickering issue on both XD84 Pro boards I have.

Side thought: Do you have the RGB underglow cycling through effects at all? or is it just a solid color and brightness?

Popkornium18 · 2020-09-07T12:58:22Z

Side thought: Do you have the RGB underglow cycling through effects at all? or is it just a solid color and brightness?

No I was using the cycling effect. With the underglow disabled the flickering goes away. 🤔

katawajojo · 2020-09-07T15:07:01Z

Side thought: Do you have the RGB underglow cycling through effects at all? or is it just a solid color and brightness?

No I was using the cycling effect. With the underglow disabled the flickering goes away. 🤔

Okay, yeah, underglow effects can still cause issues with backlight flickering. If you read through that pull request, it mentions this. Iirc, this is just a bug within QMK itself.

keyboards/xd84pro/config.h

keyboards/xd84pro/rules.mk

Co-authored-by: Ryan <[email protected]>

keyboards/xd84pro/info.json

Co-authored-by: Ryan <[email protected]>

katawajojo · 2020-10-29T18:22:11Z

For future knowledge, should I forgo using "key_count" in the info.json?

fauxpark · 2020-10-29T18:23:33Z

Yep. It's not really necessary as you can just count the number of elements in the layout array.

katawajojo · 2020-10-29T18:24:16Z

Yep. It's not really necessary as you can just count the number of elements in the layout array.

Huh! I never thought about that. Good to know, thanks! c:

fauxpark

Whoops, one last thing then I think this is good to go.

keyboards/xd84pro/info.json

Co-authored-by: Ryan <[email protected]>

katawajojo · 2020-10-30T15:29:55Z

I also just updated the VIA .json file and updated the VIA pull request as well. This should complete the VIA and QMK port for this PCB.

katawajojo · 2020-11-04T00:22:01Z

Any update on this?

fauxpark · 2020-11-04T00:39:07Z

Thanks!

Co-authored-by: Ryan <[email protected]> Co-authored-by: katawajojo <vibri@localhost> Co-authored-by: katawajojo <[email protected]>

* upstream/master: (153 commits) [Keymap] add brandonschlack userspace and keymaps (qmk#10411) [Keymap] add ai03/polaris:mekberg (qmk#10508) CLI: Add `qmk clean` (qmk#10785) Adds support for XD84 Pro (qmk#9750) Freyr refactor (qmk#10833) KC60 refactor (qmk#10834) [Keyboard] Fixes for PloopyCo mouse and readmes (qmk#10841) Enable extrakeys, mousekeys for all VIA keymaps. (qmk#10740) Add OLED support for Riblee F411 (qmk#10778) NK65 eeprom compatibility with 128KB and 256KB (qmk#10804) Add support for Noxary Vulcan (qmk#10822) Enable media keys support for Canoe VIA keymap (qmk#10829) Phantom refactor (qmk#10805) `qmk info`: Add `--ascii` flag (qmk#10793) [Keymap] Corrected the dvorak layout for kinesis advantage (qmk#10808) [Keyboard] Fix keyboard matrix scan rate with F072 (qmk#10226) [Keyboard] nullbitsco/nibble Configurator rework (qmk#10814) [Keyboard] VIA Support: Exent 65% (qmk#10797) [Keyboard] Add keebsforall/freebird60 (qmk#10774) add 65_ansi_split_bs to default community layouts (qmk#10770) ...

* upstream/master: (48 commits) [Keymap] idobo:egstad (qmk#10783) Adding few Korean translated files (qmk#5895) [Keyboard] Keebwerk MEGA Initial commit (qmk#10777) Indicator LEDs as config (qmk#10816) add missing physical layout options and VIA support for Sesame (qmk#10471) [Keyboard] Fix unused variables in mschwingen modelm (qmk#10811) Add big spacebar defaults to Underscore33 (qmk#10731) Add qmk info -l to show the layouts too (qmk#10882) New command: qmk lint (qmk#10761) Updates to Talljoe's Keymaps (qmk#10115) [Keymap] bcat keymaps and userspace (qmk#10705) add dp60 indicator mode (qmk#8801) E85 backlight & LED indicator updates (qmk#10678) Add support for 4 IS31FL3731 devices (qmk#10860) [Keymap] add brandonschlack userspace and keymaps (qmk#10411) [Keymap] add ai03/polaris:mekberg (qmk#10508) CLI: Add `qmk clean` (qmk#10785) Adds support for XD84 Pro (qmk#9750) Freyr refactor (qmk#10833) KC60 refactor (qmk#10834) ...

Adds support for XD84 Pro

bb49964

Adds QMK support for KPRepublic's XD84 Pro PCB. Includes ANSI, ISO, and VIA (ANSI layout only currently) Support.

katawajojo mentioned this pull request Jul 18, 2020

Adds support for XD84 Pro the-via/keyboards#217

Merged

6 tasks

katawajojo added 2 commits July 18, 2020 04:42

[XD84 Pro] Update readme.md

aee5697

[XD84 Pro] Update readme.md

2d41b3e

fixed make code snippet

fauxpark requested changes Jul 18, 2020

View reviewed changes

fauxpark added keyboard via Adds via keymap and/or updates keyboard for via support labels Jul 18, 2020

fauxpark requested a review from a team July 18, 2020 12:47

updates X84 Pro files. Temp debug.

009daf7

stale bot added the awaiting changes label Sep 2, 2020

Removes debug.

1fc18ee

stale bot removed the awaiting changes label Sep 5, 2020

Removes VIA keymap

e06818a

Removing VIA for the time being. I'll need to sit and figure this one out.

drashna approved these changes Sep 7, 2020

View reviewed changes

drashna requested a review from a team September 7, 2020 01:43

katawajojo requested review from fauxpark and removed request for a team September 7, 2020 04:35

fauxpark requested changes Sep 12, 2020

View reviewed changes

keyboards/xd84pro/config.h Outdated Show resolved Hide resolved

keyboards/xd84pro/config.h Outdated Show resolved Hide resolved

keyboards/xd84pro/rules.mk Outdated Show resolved Hide resolved

katawajojo and others added 2 commits September 13, 2020 03:37

Update keyboards/xd84pro/config.h

69af7c4

Co-authored-by: Ryan <[email protected]>

Update keyboards/xd84pro/rules.mk

193620c

Co-authored-by: Ryan <[email protected]>

katawajojo and others added 6 commits October 29, 2020 11:18

Update keyboards/xd84pro/rules.mk

58ac658

Co-authored-by: Ryan <[email protected]>

Update keyboards/xd84pro/xd84pro.h

57f6704

Co-authored-by: Ryan <[email protected]>

Update keyboards/xd84pro/keymaps/via/keymap.c

2a69864

Co-authored-by: Ryan <[email protected]>

Update keyboards/xd84pro/keymaps/via/keymap.c

eb29b82

Co-authored-by: Ryan <[email protected]>

Update keyboards/xd84pro/keymaps/via/keymap.c

2d37e84

Co-authored-by: Ryan <[email protected]>

Update keyboards/xd84pro/keymaps/via/keymap.c

5dc7678

Co-authored-by: Ryan <[email protected]>

fauxpark requested changes Oct 29, 2020

View reviewed changes

keyboards/xd84pro/info.json Outdated Show resolved Hide resolved

keyboards/xd84pro/info.json Outdated Show resolved Hide resolved

katawajojo and others added 2 commits October 29, 2020 11:21

Update keyboards/xd84pro/info.json

a207485

Co-authored-by: Ryan <[email protected]>

Update keyboards/xd84pro/info.json

883637b

Co-authored-by: Ryan <[email protected]>

fauxpark requested changes Oct 29, 2020

View reviewed changes

keyboards/xd84pro/info.json Outdated Show resolved Hide resolved

Update keyboards/xd84pro/info.json

18706aa

Co-authored-by: Ryan <[email protected]>

fauxpark approved these changes Oct 29, 2020

View reviewed changes

fauxpark requested review from noroadsleft and a team October 29, 2020 18:29

fauxpark merged commit d46fa22 into qmk:master Nov 4, 2020

ringmaster pushed a commit to ringmaster/qmk_firmware that referenced this pull request Nov 5, 2020

Adds support for XD84 Pro (qmk#9750)

aa943eb

Co-authored-by: Ryan <[email protected]> Co-authored-by: katawajojo <vibri@localhost> Co-authored-by: katawajojo <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds support for XD84 Pro #9750

Adds support for XD84 Pro #9750

katawajojo commented Jul 18, 2020

katawajojo commented Jul 18, 2020

sigprof commented Jul 18, 2020

stale bot commented Sep 2, 2020

Popkornium18 commented Sep 4, 2020

katawajojo commented Sep 5, 2020

katawajojo commented Sep 5, 2020 •

edited

Loading

Popkornium18 commented Sep 5, 2020

katawajojo commented Sep 5, 2020 •

edited

Loading

Popkornium18 commented Sep 7, 2020 •

edited

Loading

katawajojo commented Sep 7, 2020

katawajojo commented Oct 29, 2020

fauxpark commented Oct 29, 2020

katawajojo commented Oct 29, 2020

fauxpark left a comment

katawajojo commented Oct 30, 2020

katawajojo commented Nov 4, 2020

fauxpark commented Nov 4, 2020

Adds support for XD84 Pro #9750

Adds support for XD84 Pro #9750

Conversation

katawajojo commented Jul 18, 2020

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

katawajojo commented Jul 18, 2020

sigprof commented Jul 18, 2020

stale bot commented Sep 2, 2020

Popkornium18 commented Sep 4, 2020

katawajojo commented Sep 5, 2020

katawajojo commented Sep 5, 2020 • edited Loading

Popkornium18 commented Sep 5, 2020

katawajojo commented Sep 5, 2020 • edited Loading

Popkornium18 commented Sep 7, 2020 • edited Loading

katawajojo commented Sep 7, 2020

katawajojo commented Oct 29, 2020

fauxpark commented Oct 29, 2020

katawajojo commented Oct 29, 2020

fauxpark left a comment

Choose a reason for hiding this comment

katawajojo commented Oct 30, 2020

katawajojo commented Nov 4, 2020

fauxpark commented Nov 4, 2020

katawajojo commented Sep 5, 2020 •

edited

Loading

katawajojo commented Sep 5, 2020 •

edited

Loading

Popkornium18 commented Sep 7, 2020 •

edited

Loading