Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for XD84 Pro #217

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Adds support for XD84 Pro #217

merged 2 commits into from
Nov 10, 2020

Conversation

katawajojo
Copy link
Contributor

@katawajojo katawajojo commented Jul 18, 2020

ANSI only currently

Edit: All layouts have been added

Adds support for KPRepublic's XD84 Pro PCB.

Description

The silkscreen on the PCB also refers to this board as "XD84 v2.0"

QMK Pull Request

qmk/qmk_firmware#9750

Checklist

  • The QMK source code follows the guide here: https://caniusevia.com/docs/configuring_qmk
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

ANSI only currently
@wilba wilba added the pending QMK merge Waiting for merge into QMK master label Aug 4, 2020
@katawajojo
Copy link
Contributor Author

I need to hold off on this for a little bit, since I'm cleaning up the file to add ISO support, plus all board configurations. The QMK merge should be happening soon, so I should have this done by the weekend.

Removes ANSI-only design. Adds a complete design including all keyboard layouts for this keyboard.
@katawajojo
Copy link
Contributor Author

Okay, this should complete the full VIA and QMK port for the XD84 Pro PCB. I've tested all layouts and verify they work correctly.

@katawajojo
Copy link
Contributor Author

The QMK pull request has been merged!

@katawajojo
Copy link
Contributor Author

@Wilba6582 pinging you since you were the last one to show this request any activity.

@wilba wilba merged commit e538547 into the-via:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending QMK merge Waiting for merge into QMK master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants