Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding few Korean translated files #5895

Merged
merged 3 commits into from
Nov 9, 2020
Merged

Conversation

SeungheonOh
Copy link
Contributor

@SeungheonOh SeungheonOh commented May 17, 2019

Korean Translation

Description

Just adding few Korean translated files, planning to translate more documentations to korean

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My change requires a change to the documentation.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Korean Translation
@fauxpark
Copy link
Member

I think these should be under the subfolder ko or ko-kr, if we're using ISO 639-1 kr is not Korean: https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes

@drashna
Copy link
Member

drashna commented May 17, 2019

@jackhumbert

@SeungheonOh
Copy link
Contributor Author

I think these should be under the subfolder ko or ko-kr, if we're using ISO 639-1 kr is not Korean: https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes

Gotcha, I'll fix it this afternoon!

@SeungheonOh
Copy link
Contributor Author

Directory name have been updated. As well as full translation of 'getting_started_build_tools.md'

@SeungheonOh
Copy link
Contributor Author

getting_started_getting_help.md and getting_started_github.md have also translated
: )

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't read a word of it, but ... looks good?

@qmk/collaborators should this be merged?

@drashna drashna requested review from a team and removed request for fredizzimo July 30, 2019 07:19
@tzarc
Copy link
Member

tzarc commented Nov 9, 2020

Two approvals, assuming this is all good.

@tzarc tzarc merged commit cb80b59 into qmk:master Nov 9, 2020
ChrissiQ pushed a commit to ChrissiQ/qmk_firmware that referenced this pull request Nov 10, 2020
* Korean Translation

Korean Translation

* Korean translation

* more Korean translations
nicsuzor added a commit to nicsuzor/qmk_firmware that referenced this pull request Nov 14, 2020
* upstream/master: (48 commits)
  [Keymap] idobo:egstad (qmk#10783)
  Adding few Korean translated files (qmk#5895)
  [Keyboard] Keebwerk MEGA Initial commit (qmk#10777)
  Indicator LEDs as config (qmk#10816)
  add missing physical layout options and VIA support for Sesame (qmk#10471)
  [Keyboard] Fix unused variables in mschwingen modelm (qmk#10811)
  Add big spacebar defaults to Underscore33 (qmk#10731)
  Add qmk info -l to show the layouts too (qmk#10882)
  New command: qmk lint (qmk#10761)
  Updates to Talljoe's Keymaps (qmk#10115)
  [Keymap] bcat keymaps and userspace (qmk#10705)
  add dp60 indicator mode (qmk#8801)
  E85 backlight & LED indicator updates (qmk#10678)
  Add support for 4 IS31FL3731 devices (qmk#10860)
  [Keymap] add brandonschlack userspace and keymaps (qmk#10411)
  [Keymap] add ai03/polaris:mekberg (qmk#10508)
  CLI: Add `qmk clean` (qmk#10785)
  Adds support for XD84 Pro (qmk#9750)
  Freyr refactor (qmk#10833)
  KC60 refactor (qmk#10834)
  ...
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Korean Translation

Korean Translation

* Korean translation

* more Korean translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants