Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated VIA Support for DP60 #9508

Merged
merged 15 commits into from
Jul 5, 2020
Merged

Updated VIA Support for DP60 #9508

merged 15 commits into from
Jul 5, 2020

Conversation

paulgali
Copy link
Contributor

@paulgali paulgali commented Jun 22, 2020

Updated for VIA support since VIAs overhaul.

Description

  • Changed ______ to KC_TRNS in \via\keymap.c
  • Included Underglow settings on the rules.mk VIA directory
  • Updated Product Name in config.h (formerly "Dumplings")
    EDIT:
  • Added LAYOUT_all for via

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@paulgali
Copy link
Contributor Author

image

RGB confirmed as configurable in VIA

@paulgali paulgali marked this pull request as draft June 23, 2020 11:33
- Updated default dp60\layouts\via\keymap.c to mmirror changes to 
LAYOUT_all
- Rules.mk updated in both base and via directories.
@paulgali
Copy link
Contributor Author

Final changes have been made. The board has been tested in VIA and is working well. KLE is here

@paulgali paulgali marked this pull request as ready for review June 23, 2020 19:35
@paulgali paulgali changed the title Updated VIA Support Updated VIA Support for DP60 Jun 23, 2020
@zvecr zvecr added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 23, 2020
@paulgali
Copy link
Contributor Author

Changed default VIA layouts. Only a Quality of life Keymap update before this is merged. Final Change.

https://imgur.com/a/A2QwEbQ

keyboards/dp60/config.h Outdated Show resolved Hide resolved
keyboards/dp60/dp60.h Outdated Show resolved Hide resolved
keyboards/dp60/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/dp60/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/dp60/keymaps/via/rules.mk Outdated Show resolved Hide resolved
keyboards/dp60/rules.mk Outdated Show resolved Hide resolved
@paulgali
Copy link
Contributor Author

@fauxpark all changes committed

keyboards/dp60/keymaps/via/rules.mk Outdated Show resolved Hide resolved
@paulgali paulgali requested a review from zvecr July 1, 2020 08:56
@drashna drashna merged commit 83bc0b9 into qmk:master Jul 5, 2020
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Jul 6, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (154 commits)
  Fix typo in freebsd_install.sh (qmk#9655)
  [Keymap] Add Alice rev2 to my userspace (qmk#9600)
  [Keyboard] RART67 : add support via (qmk#9589)
  [Keyboard] XD87 Caps Lock LED refactor (qmk#9585)
  [Keyboard] Updated VIA Support for DP60 (qmk#9508)
  fixed link to Eclipse instructions (qmk#9647)
  format code according to conventions [skip ci]
  add DIP_SWITCH_MATRIX_GRID support (qmk#8772)
  add SPLIT_HAND_MATRIX_GRID support (qmk#8685)
  [Keyboard] Gowla Macro Board (qmk#9643)
  Fix “G” in Neo2 keymap (qmk#9645)
  Rotr - Updated README and default keymap (qmk#9598)
  Add missing dependency for Void Linux to util/linux-install.sh (qmk#9637)
  Backlight docs wordsmithing (qmk#9631)
  Fix incorrect layout for GHS.rar (qmk#9597)
  Add movement hook to ps2_mouse (qmk#8805)
  Make sendstring respect `TAP_CODE_DELAY` (qmk#9623)
  [Keymap] Adding a Custom Keymap for Matrix Noah (qmk#9581)
  Fix sharing of mouse button state from mousekeys to ps2_mouse (qmk#9124)
  Add xjtian keymap for Planck (qmk#9502)
  ...
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* Updated VIA Support

- Added LAYOUT_all Support for VIA compatibility
- Updated default dp60\layouts\via\keymap.c to mmirror changes to 
LAYOUT_all
- Rules.mk updated in both base and via directories.


Co-authored-by: Ryan <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants