Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Via support for dp60 pcb #179

Merged
merged 6 commits into from
Aug 4, 2020
Merged

Via support for dp60 pcb #179

merged 6 commits into from
Aug 4, 2020

Conversation

paulgali
Copy link
Contributor

@paulgali paulgali commented Jun 22, 2020

Added VIA support for the DP60

Description

Before the VIA overhaul, the DP60 was supported. There is now no JSON files inside the via category, hence I have created one for this particular PCB. It includes the variable layouts present here

Testing confirmed - https://imgur.com/a/Um3YKfx

QMK Pull Request

qmk/qmk_firmware#9508

New layout_all created specifically for configurable layouts in via. @Wilba6582 the QMK PR should go live before this I believe? Or does it make much of a difference?

Checklist

  • The QMK source code follows the guide here: https://caniusevia.com/docs/configuring_qmk
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@paulgali
Copy link
Contributor Author

Need to rework JSON, will reopen shortly

@paulgali paulgali closed this Jun 22, 2020
@paulgali paulgali reopened this Jun 23, 2020
@paulgali paulgali closed this Jun 23, 2020
@paulgali paulgali reopened this Jun 23, 2020
@paulgali
Copy link
Contributor Author

I am creating a new macro layout for the dp60, under layout_all, before this should go live. Once that is merged into QMK I will trigger this PR.

@paulgali
Copy link
Contributor Author

Testing complete. See https://imgur.com/a/Um3YKfx

@paulgali
Copy link
Contributor Author

QMK branch updated with an enhanced 'default' layout https://imgur.com/a/A2QwEbQ

Update here . QMK branch is ready to be merged.

@wilba wilba merged commit e5add34 into the-via:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants