-
-
Notifications
You must be signed in to change notification settings - Fork 40.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xjtian keymap for Planck #9502
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
813f6cd
to
5a323a9
Compare
fcca25b
to
b1fb404
Compare
fauxpark
requested changes
Jun 27, 2020
Comment on lines
7
to
10
// Most tactile encoders have detents every 4 stages | ||
#define ENCODER_RESOLUTION 4 | ||
|
||
#define TAPPING_TERM 200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// Most tactile encoders have detents every 4 stages | |
#define ENCODER_RESOLUTION 4 | |
#define TAPPING_TERM 200 |
fauxpark
approved these changes
Jul 2, 2020
Erovia
approved these changes
Jul 2, 2020
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Jul 6, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (154 commits) Fix typo in freebsd_install.sh (qmk#9655) [Keymap] Add Alice rev2 to my userspace (qmk#9600) [Keyboard] RART67 : add support via (qmk#9589) [Keyboard] XD87 Caps Lock LED refactor (qmk#9585) [Keyboard] Updated VIA Support for DP60 (qmk#9508) fixed link to Eclipse instructions (qmk#9647) format code according to conventions [skip ci] add DIP_SWITCH_MATRIX_GRID support (qmk#8772) add SPLIT_HAND_MATRIX_GRID support (qmk#8685) [Keyboard] Gowla Macro Board (qmk#9643) Fix “G” in Neo2 keymap (qmk#9645) Rotr - Updated README and default keymap (qmk#9598) Add missing dependency for Void Linux to util/linux-install.sh (qmk#9637) Backlight docs wordsmithing (qmk#9631) Fix incorrect layout for GHS.rar (qmk#9597) Add movement hook to ps2_mouse (qmk#8805) Make sendstring respect `TAP_CODE_DELAY` (qmk#9623) [Keymap] Adding a Custom Keymap for Matrix Noah (qmk#9581) Fix sharing of mouse button state from mousekeys to ps2_mouse (qmk#9124) Add xjtian keymap for Planck (qmk#9502) ...
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New layout for 4x12 grid Planck keyboards.
Types of Changes
Checklist