Fix AVR SPI parameter configuration, remove timeouts #8775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
fauxpark
approved these changes
Apr 13, 2020
calmh
added a commit
to calmh/qmk_firmware
that referenced
this pull request
Apr 13, 2020
* master: (973 commits) Fix AVR SPI parameter configuration, remove timeouts due to sync protocol. (qmk#8775) VIA Support: Jane V2 (qmk#8735) Add a simple custom keymap for Gergo. (qmk#8662) Add via support to keebio/bdn9 (qmk#8620) DP60 VIA cleanups (qmk#8697) Adding Niu Mini to VIA (qmk#8702) Allow trailing whitespace in markdown docs, for formatting purposes. (qmk#8774) Add support for hardware and board initialisation overrides. (qmk#8330) [Keyboard] Add IDOBAO ID80 (qmk#8728) [Keyboard] Quefrency Rev2 Caps Lock LED, set lighting defaults (qmk#8729) [Keyboard] Add handwired Fc200rt qmk board (qmk#8726) Bugfix for quantum/dip_switch.c (qmk#8731) Add *OPT aliases for *ALT keycodes and macros (qmk#8714) [Keymap] Add keymap for Nyquist rev3 (qmk#8706) format code according to conventions [skip ci] Added Workman ZXCVM variation (qmk#8686) [Keyboard] jotpad16 status leds (qmk#8643) [Keyboard] Add handwired BDN9-BLE (qmk#8192) Fix bug with layer caching in get_event_keycode (qmk#8693) [Keyboard] Add CannonKeys Atlas keyboard (qmk#8207) ...
Quarren42
pushed a commit
to Quarren42/qmk_firmware
that referenced
this pull request
Apr 15, 2020
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
violet-fish
pushed a commit
to violet-fish/qmk_firmware
that referenced
this pull request
May 3, 2020
bitherder
pushed a commit
to bitherder/qmk_firmware
that referenced
this pull request
May 15, 2020
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
May 24, 2020
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
May 24, 2020
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jun 12, 2020
turky
pushed a commit
to turky/qmk_firmware
that referenced
this pull request
Jun 13, 2020
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were a few issues with the SPI configuration on AVR, with wrong registers being written.
This fixes those, but also removes the external timeout parameters as it's a synchronous protocol.
Types of Changes
Checklist