Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add handwired BDN9-BLE #8192

Merged
merged 5 commits into from
Apr 12, 2020
Merged

[Keyboard] Add handwired BDN9-BLE #8192

merged 5 commits into from
Apr 12, 2020

Conversation

Merlin04
Copy link
Contributor

Description

Add BDN9-BLE, a handwired BDN9 macropad modified to add Bluetooth.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark requested changes Feb 18, 2020
View reviewed changes
keyboards/handwired/bdn9_ble/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/bdn9_ble/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/bdn9_ble/rules.mk Show resolved Hide resolved
keyboards/handwired/bdn9_ble/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/bdn9_ble/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/bdn9_ble/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/bdn9_ble/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/bdn9_ble/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team February 18, 2020 00:35
fauxpark
fauxpark requested changes Feb 18, 2020
View reviewed changes
keyboards/handwired/bdn9_ble/rules.mk Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team February 19, 2020 01:43
@drashna
Copy link
Member

drashna commented Feb 19, 2020

Just to make sure, this is a BDN9 with a bluetooth module (and battery)? Otherwise, it's identical hardware?

@noroadsleft noroadsleft requested a review from drashna February 19, 2020 19:09
@noroadsleft
Copy link
Member

Didn't see @drashna's question until after approval; will leave judgement on when to merge this to him.

@zvecr
Copy link
Member

zvecr commented Feb 19, 2020 •
edited
Loading

If just a bdn9 PCB, this could potentially just be a keymap like https://github.com/qmk/qmk_firmware/tree/master/keyboards/40percentclub/mf68/keymaps/mf68_ble

@Merlin04
Copy link
Contributor Author

Merlin04 commented Feb 19, 2020 •
edited
Loading

It's a BDN9 PCB, but an Adafruit Feather 32u4 Bluefruit LE has been connected instead of a pro micro. It does not use the same pins.

@drashna
Copy link
Member

drashna commented Feb 21, 2020

I did notice that (after commenting). Though, if this is using the original PCB ... you could just undef the pins in your config.h, and redefine them. That would remove the need to specify a new boards

And you can override the MCU speed in your keymap's rules.mk file.

Personally, I feel that this would be a better way to handle this, but I'm not opposed to merging this, as is.

@Merlin04
Copy link
Contributor Author

I think that it would work as a keymap, but I'd prefer a new keyboard because that would let me use the Configurator with it.

@drashna drashna requested a review from nooges February 23, 2020 22:37
@stale
Copy link

stale bot commented Apr 8, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

drashna
drashna approved these changes Apr 12, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stale stale bot removed the awaiting changes label Apr 12, 2020
@drashna drashna changed the title Add handwired BDN9-BLE [Keyboard] Add handwired BDN9-BLE Apr 12, 2020
@drashna drashna merged commit 6265b78 into qmk:master Apr 12, 2020
calmh added a commit to calmh/qmk_firmware that referenced this pull request Apr 13, 2020
@calmh
Merge branch 'master' into calmh
a855052 
* master: (973 commits)
  Fix AVR SPI parameter configuration, remove timeouts due to sync protocol. (qmk#8775)
  VIA Support: Jane V2 (qmk#8735)
  Add a simple custom keymap for Gergo. (qmk#8662)
  Add via support to keebio/bdn9 (qmk#8620)
  DP60 VIA cleanups (qmk#8697)
  Adding Niu Mini to VIA (qmk#8702)
  Allow trailing whitespace in markdown docs, for formatting purposes. (qmk#8774)
  Add support for hardware and board initialisation overrides. (qmk#8330)
  [Keyboard] Add IDOBAO ID80 (qmk#8728)
  [Keyboard] Quefrency Rev2 Caps Lock LED, set lighting defaults (qmk#8729)
  [Keyboard] Add handwired Fc200rt qmk board (qmk#8726)
  Bugfix for quantum/dip_switch.c (qmk#8731)
  Add *OPT aliases for *ALT keycodes and macros (qmk#8714)
  [Keymap] Add keymap for Nyquist rev3 (qmk#8706)
  format code according to conventions [skip ci]
  Added Workman ZXCVM variation (qmk#8686)
  [Keyboard] jotpad16 status leds (qmk#8643)
  [Keyboard] Add handwired BDN9-BLE (qmk#8192)
  Fix bug with layer caching in get_event_keycode (qmk#8693)
  [Keyboard] Add CannonKeys Atlas keyboard (qmk#8207)
  ...
Quarren42 pushed a commit to Quarren42/qmk_firmware that referenced this pull request Apr 15, 2020
@Merlin04 @fauxpark
@noroadsleft @Quarren42
[Keyboard] Add handwired BDN9-BLE (qmk#8192)
78e7f29 
* Add handwired BDN9-BLE

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/rules.mk

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/rules.mk

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/readme.md

Co-Authored-By: James Young <[email protected]>

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@Merlin04 @fauxpark
@noroadsleft @kujawakk
[Keyboard] Add handwired BDN9-BLE (qmk#8192)
e583459 
* Add handwired BDN9-BLE

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/rules.mk

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/rules.mk

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/readme.md

Co-Authored-By: James Young <[email protected]>

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request May 3, 2020
@Merlin04 @fauxpark
@noroadsleft @violet-fish
[Keyboard] Add handwired BDN9-BLE (qmk#8192)
4b03a3c 
* Add handwired BDN9-BLE

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/rules.mk

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/rules.mk

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/readme.md

Co-Authored-By: James Young <[email protected]>

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@Merlin04 @fauxpark
@noroadsleft @lorenzoernesto
[Keyboard] Add handwired BDN9-BLE (qmk#8192)
bb636ca 
* Add handwired BDN9-BLE

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/rules.mk

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/rules.mk

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/readme.md

Co-Authored-By: James Young <[email protected]>

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@Merlin04 @fauxpark
@noroadsleft @sowbug
[Keyboard] Add handwired BDN9-BLE (qmk#8192)
c325211 
* Add handwired BDN9-BLE

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/rules.mk

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/rules.mk

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/readme.md

Co-Authored-By: James Young <[email protected]>

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@Merlin04 @fauxpark
@noroadsleft @turky
[Keyboard] Add handwired BDN9-BLE (qmk#8192)
e55d2b2 
* Add handwired BDN9-BLE

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/rules.mk

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/rules.mk

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/readme.md

Co-Authored-By: James Young <[email protected]>

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@Merlin04 @fauxpark
@noroadsleft @jakobaa
[Keyboard] Add handwired BDN9-BLE (qmk#8192)
bbd1ad8 
* Add handwired BDN9-BLE

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/rules.mk

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/rules.mk

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/handwired/bdn9_ble/readme.md

Co-Authored-By: James Young <[email protected]>

Co-authored-by: Ryan <[email protected]>
Co-authored-by: James Young <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@nooges nooges Awaiting requested review from nooges

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Merlin04 @drashna @noroadsleft @zvecr @fauxpark