Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Quefrency Rev2 Caps Lock LED, set lighting defaults #8729

Merged
merged 5 commits into from
Apr 12, 2020
Merged

[Keyboard] Quefrency Rev2 Caps Lock LED, set lighting defaults #8729

merged 5 commits into from
Apr 12, 2020

Conversation

nooges
Copy link
Member

@nooges nooges commented Apr 7, 2020

Description

Adds initial support for the Caps Lock LED on Quefrency Rev. 2. Only works if USB is plugged into left half, as no syncing of led_state is done over halves at the moment.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

nooges added 3 commits April 9, 2020 00:54
@nooges
Add support for Caps Lock LED
11adcba 
Currently ignores the fact that led_state is not synced between halves, so caps lock LED doesn't do anything if USB is plugged into right half
@nooges
Set initial backlight and RGB mode/values on blank EEPROM
4d3f2a9
@nooges
Set default VIA layout options
e282e7a
@nooges nooges force-pushed the quefrency-rev2-caps-led branch from 776d3e7 to e282e7a Compare April 9, 2020 06:01
@nooges nooges force-pushed the quefrency-rev2-caps-led branch from 9de87ea to 44c65c9 Compare April 9, 2020 16:02
@nooges nooges changed the title Add support for Quefrency Rev2 Caps Lock LED Add support for Quefrency Rev2 Caps Lock LED, set lighting defaults Apr 9, 2020
@drashna drashna requested a review from a team April 12, 2020 19:58
@drashna drashna changed the title Add support for Quefrency Rev2 Caps Lock LED, set lighting defaults [Keyboard] Quefrency Rev2 Caps Lock LED, set lighting defaults Apr 12, 2020
@drashna drashna merged commit 46a69d1 into qmk:master Apr 12, 2020
calmh added a commit to calmh/qmk_firmware that referenced this pull request Apr 13, 2020
@calmh
Merge branch 'master' into calmh
a855052 
* master: (973 commits)
  Fix AVR SPI parameter configuration, remove timeouts due to sync protocol. (qmk#8775)
  VIA Support: Jane V2 (qmk#8735)
  Add a simple custom keymap for Gergo. (qmk#8662)
  Add via support to keebio/bdn9 (qmk#8620)
  DP60 VIA cleanups (qmk#8697)
  Adding Niu Mini to VIA (qmk#8702)
  Allow trailing whitespace in markdown docs, for formatting purposes. (qmk#8774)
  Add support for hardware and board initialisation overrides. (qmk#8330)
  [Keyboard] Add IDOBAO ID80 (qmk#8728)
  [Keyboard] Quefrency Rev2 Caps Lock LED, set lighting defaults (qmk#8729)
  [Keyboard] Add handwired Fc200rt qmk board (qmk#8726)
  Bugfix for quantum/dip_switch.c (qmk#8731)
  Add *OPT aliases for *ALT keycodes and macros (qmk#8714)
  [Keymap] Add keymap for Nyquist rev3 (qmk#8706)
  format code according to conventions [skip ci]
  Added Workman ZXCVM variation (qmk#8686)
  [Keyboard] jotpad16 status leds (qmk#8643)
  [Keyboard] Add handwired BDN9-BLE (qmk#8192)
  Fix bug with layer caching in get_event_keycode (qmk#8693)
  [Keyboard] Add CannonKeys Atlas keyboard (qmk#8207)
  ...
Quarren42 pushed a commit to Quarren42/qmk_firmware that referenced this pull request Apr 15, 2020
@nooges @Quarren42
[Keyboard] Quefrency Rev2 Caps Lock LED, set lighting defaults (qmk#8729
cded5f4 
)

* Add support for Caps Lock LED

Currently ignores the fact that led_state is not synced between halves, so caps lock LED doesn't do anything if USB is plugged into right half

* Set initial backlight and RGB mode/values on blank EEPROM

* Set default VIA layout options

* Add backlight/RGB ifdefs

* Set bootloaders for each rev
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@nooges @kujawakk
[Keyboard] Quefrency Rev2 Caps Lock LED, set lighting defaults (qmk#8729
1cedbad 
)

* Add support for Caps Lock LED

Currently ignores the fact that led_state is not synced between halves, so caps lock LED doesn't do anything if USB is plugged into right half

* Set initial backlight and RGB mode/values on blank EEPROM

* Set default VIA layout options

* Add backlight/RGB ifdefs

* Set bootloaders for each rev
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request May 3, 2020
@nooges @violet-fish
[Keyboard] Quefrency Rev2 Caps Lock LED, set lighting defaults (qmk#8729
1aa26e2 
)

* Add support for Caps Lock LED

Currently ignores the fact that led_state is not synced between halves, so caps lock LED doesn't do anything if USB is plugged into right half

* Set initial backlight and RGB mode/values on blank EEPROM

* Set default VIA layout options

* Add backlight/RGB ifdefs

* Set bootloaders for each rev
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@nooges @lorenzoernesto
[Keyboard] Quefrency Rev2 Caps Lock LED, set lighting defaults (qmk#8729
043bef4 
)

* Add support for Caps Lock LED

Currently ignores the fact that led_state is not synced between halves, so caps lock LED doesn't do anything if USB is plugged into right half

* Set initial backlight and RGB mode/values on blank EEPROM

* Set default VIA layout options

* Add backlight/RGB ifdefs

* Set bootloaders for each rev
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@nooges @sowbug
[Keyboard] Quefrency Rev2 Caps Lock LED, set lighting defaults (qmk#8729
e65d3f2 
)

* Add support for Caps Lock LED

Currently ignores the fact that led_state is not synced between halves, so caps lock LED doesn't do anything if USB is plugged into right half

* Set initial backlight and RGB mode/values on blank EEPROM

* Set default VIA layout options

* Add backlight/RGB ifdefs

* Set bootloaders for each rev
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@nooges @turky
[Keyboard] Quefrency Rev2 Caps Lock LED, set lighting defaults (qmk#8729
0628b4e 
)

* Add support for Caps Lock LED

Currently ignores the fact that led_state is not synced between halves, so caps lock LED doesn't do anything if USB is plugged into right half

* Set initial backlight and RGB mode/values on blank EEPROM

* Set default VIA layout options

* Add backlight/RGB ifdefs

* Set bootloaders for each rev
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@nooges @jakobaa
[Keyboard] Quefrency Rev2 Caps Lock LED, set lighting defaults (qmk#8729
474b1ec 
)

* Add support for Caps Lock LED

Currently ignores the fact that led_state is not synced between halves, so caps lock LED doesn't do anything if USB is plugged into right half

* Set initial backlight and RGB mode/values on blank EEPROM

* Set default VIA layout options

* Add backlight/RGB ifdefs

* Set bootloaders for each rev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nooges @drashna @fauxpark