Allows Terminal to use ModTap/LayerTap keys #4586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jackhumbert, this look good? |
|
This is not just about enter key, if you for example map any alpha key to be mod tap, without this fix it won't work. For example i mapped my With this fix, every mod tap key is registered normally. |
|
I should probably also add layer tap (LT) |
akrob
pushed a commit
to akrob/qmk_firmware
that referenced
this pull request
Jan 19, 2019
* upstream/master: (390 commits) [Keyboard] handwired/ortho60 Configurator update, readme update, and rules tidy (qmk#4877) Fix Encoder documentation (qmk#4861) TKC1800 refactor and Configurator visual fixes (qmk#4870) Fixed the build break of helix/rev1:OLED_sample caused by PR qmk#4462. (qmk#4874) Add cursor keys to top layer (qmk#4876) [Keyboard] Fix bootloader size for v60_type_r (qmk#4873) Flip definitions of macOS brightness alias Grammatical fixes for GPIO Control doc (qmk#4869) handwired/ortho5x13: layout macro refactor Add new brightness aliases to keycodes_basic.md [Keyboard] update VENDOR_ID, PRODUCT_ID, and DEVICE_VER for Duck boards (qmk#4612) Add Planck rev1 and rev2, clean up rev3-5 config.h Allows Terminal to use ModTap/LayerTap keys (qmk#4586) Defined IS_(HOST_)LED_ON/OFF() and improved LED documentation (qmk#4853) MacOS Brightness Alias (qmk#4836) [Keymap] added custom led effect keymap.c (qmk#4856) Simplify split_common Code significantly (qmk#4772) Add documentation and fix formating (qmk#4860) [Keymap] Adding bdk keymap for ergobox_ez (qmk#4850) 40percent.club Luddite: Configurator update (qmk#4859) ...
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue described in #4583
Types of changes
Issues Fixed or Closed by this PR
Checklist: