Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update VENDOR_ID, PRODUCT_ID, and DEVICE_VER for Duck boards #4612

Merged
merged 3 commits into from
Jan 18, 2019
Merged

update VENDOR_ID, PRODUCT_ID, and DEVICE_VER for Duck boards #4612

merged 3 commits into from
Jan 18, 2019

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Dec 12, 2018 •
edited
Loading

Description

Update IDs associated with Duck boards to uniquely identify them for future VIA support. Copy pasta all around has resulted in almost all QMK supported boards with the same vendor and product ids.

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechmerlin mechmerlin requested a review from drashna December 12, 2018 19:14
@drashna
Copy link
Member

drashna commented Dec 12, 2018

Does the normal firmware for the Duck boards use these ID's?

@mechmerlin
Copy link
Contributor Author

Does the normal firmware for the Duck boards use these ID's?

I've actually never checked, and I'm not touching o2d with a ten foot pole ever again.

@drashna
Copy link
Member

drashna commented Dec 12, 2018

Is VIA officially supporting them?

And are these in use?

@wilba
Copy link
Contributor

wilba commented Dec 12, 2018

FWIW VIA Configurator doesn't use DEVICE_VER, only VENDOR_ID and PRODUCT_ID. There is the assumption that devices with that unique pair will have the same layout and matrix (rows/columns). So, don't use DEVICE_VER as a way to differentiate between two versions of the same device; encode that into PRODUCT_ID. Note if two versions of a device just differ by PCB layout, I/O pin usage, slightly different firmware code, etc. then it's OK for them to have the same VENDOR_ID and PRODUCT_ID.

@mechmerlin
Copy link
Contributor Author

Unsure how many other versions if any the other Duck boards will have. Incorporated Wilba's suggestions into the Octagon V1/V2 for the time being.

@drashna drashna merged commit ade6f8e into qmk:master Jan 18, 2019
akrob pushed a commit to akrob/qmk_firmware that referenced this pull request Jan 19, 2019
Merge remote-tracking branch 'upstream/master'
a8a9bd1 
* upstream/master: (390 commits)
  [Keyboard] handwired/ortho60 Configurator update, readme update, and rules tidy (qmk#4877)
  Fix Encoder documentation (qmk#4861)
  TKC1800 refactor and Configurator visual fixes (qmk#4870)
  Fixed the build break of helix/rev1:OLED_sample caused by PR qmk#4462. (qmk#4874)
  Add cursor keys to top layer (qmk#4876)
  [Keyboard] Fix bootloader size for v60_type_r (qmk#4873)
  Flip definitions of macOS brightness alias
  Grammatical fixes for GPIO Control doc (qmk#4869)
  handwired/ortho5x13: layout macro refactor
  Add new brightness aliases to keycodes_basic.md
  [Keyboard] update VENDOR_ID, PRODUCT_ID, and DEVICE_VER for Duck boards (qmk#4612)
  Add Planck rev1 and rev2, clean up rev3-5 config.h
  Allows Terminal to use ModTap/LayerTap keys (qmk#4586)
  Defined IS_(HOST_)LED_ON/OFF() and improved LED documentation (qmk#4853)
  MacOS Brightness Alias (qmk#4836)
  [Keymap] added custom led effect keymap.c (qmk#4856)
  Simplify split_common Code significantly (qmk#4772)
  Add documentation and fix formating (qmk#4860)
  [Keymap] Adding bdk keymap for ergobox_ez (qmk#4850)
  40percent.club Luddite: Configurator update (qmk#4859)
  ...
@mechmerlin mechmerlin deleted the feature/duck_ids branch February 15, 2019 03:48
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@mechmerlin
[Keyboard] update VENDOR_ID, PRODUCT_ID, and DEVICE_VER for Duck boar…
def9837 
…ds (qmk#4612)

* change VENDOR_ID, PRODUCT_ID, and DEVICE_VER as step one in getting VIA support

* fix v1 product id

* VIA doesn't use the version, so we need to encode it into PRODUCT_ID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft left review comments

@drashna drashna drashna approved these changes

@fredizzimo fredizzimo Awaiting requested review from fredizzimo

@jackhumbert jackhumbert Awaiting requested review from jackhumbert

@skullydazed skullydazed Awaiting requested review from skullydazed

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mechmerlin @drashna @wilba @noroadsleft