Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TERMINAL_ENABLE feature doesn't work with Mod-Tap Enter #4583

Closed
3 tasks
chax opened this issue Dec 9, 2018 · 1 comment · Fixed by #4586
Closed
3 tasks

TERMINAL_ENABLE feature doesn't work with Mod-Tap Enter #4583

chax opened this issue Dec 9, 2018 · 1 comment · Fixed by #4586

Comments

@chax
Copy link
Contributor

chax commented Dec 9, 2018

When using TERMINAL_ENABLE feature, and your enter key is configured as Mod-Tap, terminal doesn't output anything except initial prompt. Problem is, enter configured this way is not recognized in process_terminal.c

System Information

  • Keyboard:
    Planck rev6
  • Operating System:
    Linux Solus
  • avr-gcc version:
    avr-gcc (GCC) 8.2.0
  • arm gcc version:
    arm-none-eabi-gcc (GNU Tools for Arm Embedded Processors 7-2018-q2-update) 7.3.1 20180622 (release) [ARM/embedded-7-branch revision 261907]
  • QMK Firmware version:
    0.6.199
  • Any keyboard related software installed?
    • Auto Hot Key
    • Karabiner
    • Other

Additional context

if (keycode < 256) {
uint8_t str_len;
char char_to_add;
switch (keycode) {
case KC_ENTER:
push_to_cmd_buffer();
current_cmd_buffer_pos = 0;
process_terminal_command();
return false; break;
case KC_ESC:

When i configure my enter key in my keymap.c as KC_ENT everything works, but my enter is configured as RSFT_T(KC_ENT) and then it doesn't work. My workaround is to have KC_ENT in Raise layer.

@chax
Copy link
Contributor Author

chax commented Dec 9, 2018

KC_PENT also doesn't work

chax added a commit to chax/qmk_firmware that referenced this issue Dec 10, 2018
chax added a commit to chax/qmk_firmware that referenced this issue Dec 10, 2018
drashna pushed a commit that referenced this issue Jan 18, 2019
* fixes #4583

* #4583 - terminal also handles layer tap now
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this issue May 24, 2019
* fixes qmk#4583

* qmk#4583 - terminal also handles layer tap now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant