Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor LED Breathing effect with runner #24540

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Refactor LED Breathing effect with runner #24540

merged 1 commit into from
Oct 28, 2024

Conversation

filterpaper
Copy link
Contributor

Description

Simplify effect using an existing runner

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@filterpaper
Refactor LED Breathing effect with runner
9efd871 
Simplify effect using an existing runner
@fauxpark fauxpark requested a review from a team October 28, 2024 05:57
@github-actions github-actions bot added the core label Oct 28, 2024
@drashna drashna merged commit 06b7dce into qmk:develop Oct 28, 2024
4 checks passed
@filterpaper filterpaper deleted the ledbreathing-refactor branch October 28, 2024 22:47
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
@filterpaper @ilham-agustiawan
Refactor LED Breathing effect with runner (qmk#24540)
8a94615
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
@filterpaper @smallketchup82
Refactor LED Breathing effect with runner (qmk#24540)
77b553c
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
@filterpaper @jlaptavi
Refactor LED Breathing effect with runner (qmk#24540)
c525e0d
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@filterpaper @DmNosachev
Refactor LED Breathing effect with runner (qmk#24540)
9c3beaf
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@filterpaper @SyrupSplashin
Refactor LED Breathing effect with runner (qmk#24540)
2ee3eab
LeonMusCoden pushed a commit to LeonMusCoden/qmk_firmware that referenced this pull request Jan 5, 2025
@filterpaper @LeonMusCoden
Refactor LED Breathing effect with runner (qmk#24540)
4d0c54d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @drashna @fauxpark