Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LED Breathing effect with runner #24540

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Refactor LED Breathing effect with runner #24540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions quantum/led_matrix/animations/breathing_anim.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,12 @@
LED_MATRIX_EFFECT(BREATHING)
# ifdef LED_MATRIX_CUSTOM_EFFECT_IMPLS

bool BREATHING(effect_params_t* params) {
LED_MATRIX_USE_LIMITS(led_min, led_max);
static uint8_t BREATHING_math(uint8_t val, uint8_t i, uint8_t time) {
return scale8(abs8(sin8(time / 2) - 128) * 2, val);
}

uint8_t val = led_matrix_eeconfig.val;
uint16_t time = scale16by8(g_led_timer, led_matrix_eeconfig.speed / 8);
val = scale8(abs8(sin8(time) - 128) * 2, val);
for (uint8_t i = led_min; i < led_max; i++) {
LED_MATRIX_TEST_LED_FLAGS();
led_matrix_set_value(i, val);
}
return led_matrix_check_finished_leds(led_max);
bool BREATHING(effect_params_t* params) {
return effect_runner_i(params, &BREATHING_math);
}

# endif // LED_MATRIX_CUSTOM_EFFECT_IMPLS
Expand Down