Refactor LED Breathing effect with runner (qmk#24540)

SyrupSplashin · Dec 10, 2024 · 2ee3eab · 2ee3eab
1 parent 8fbc76c
commit 2ee3eab
Showing 1 changed file with 5 additions and 10 deletions.
diff --git a/quantum/led_matrix/animations/breathing_anim.h b/quantum/led_matrix/animations/breathing_anim.h
@@ -2,17 +2,12 @@
 LED_MATRIX_EFFECT(BREATHING)
 #    ifdef LED_MATRIX_CUSTOM_EFFECT_IMPLS
 
-bool BREATHING(effect_params_t* params) {
-    LED_MATRIX_USE_LIMITS(led_min, led_max);
+static uint8_t BREATHING_math(uint8_t val, uint8_t i, uint8_t time) {
+    return scale8(abs8(sin8(time / 2) - 128) * 2, val);
+}
 
-    uint8_t  val  = led_matrix_eeconfig.val;
-    uint16_t time = scale16by8(g_led_timer, led_matrix_eeconfig.speed / 8);
-    val           = scale8(abs8(sin8(time) - 128) * 2, val);
-    for (uint8_t i = led_min; i < led_max; i++) {
-        LED_MATRIX_TEST_LED_FLAGS();
-        led_matrix_set_value(i, val);
-    }
-    return led_matrix_check_finished_leds(led_max);
+bool BREATHING(effect_params_t* params) {
+    return effect_runner_i(params, &BREATHING_math);
 }
 
 #    endif // LED_MATRIX_CUSTOM_EFFECT_IMPLS