Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate RGBLight/RGB Matrix keycode handling #23679

Merged
merged 10 commits into from
Oct 12, 2024
Merged

Separate RGBLight/RGB Matrix keycode handling #23679

merged 10 commits into from
Oct 12, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented May 7, 2024 •
edited
Loading

Description

  • Renamed process_rgb to process_underglow; removed all RGB Matrix-specific code
  • Added process_rgb_matrix.[ch]

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team May 7, 2024 09:14
@github-actions github-actions bot added keyboard keymap documentation via Adds via keymap and/or updates keyboard for via support labels May 7, 2024
@fauxpark fauxpark mentioned this pull request May 10, 2024
Merged
14 tasks
@fauxpark fauxpark mentioned this pull request May 22, 2024
Merged
14 tasks
@tzarc tzarc added breaking_change_2024q3 develop-fast-track Intended to be merged early in the next develop cycle. and removed breaking_change_2024q2 labels May 27, 2024
@drashna drashna requested a review from a team May 30, 2024 18:28
@fauxpark fauxpark mentioned this pull request Jun 11, 2024
Merged
14 tasks
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 29, 2024
@KarlK90
Copy link
Member

KarlK90 commented Oct 6, 2024

Hi @fauxpark there are now merge conflicts that prevent this PR from being merged.

@fauxpark
Copy link
Member Author

@KarlK90 fixed.

@KarlK90 KarlK90 merged commit 6fa11bf into qmk:develop Oct 12, 2024
5 of 6 checks passed
@fauxpark fauxpark deleted the rgb-keycodes-separate branch October 13, 2024 00:11
This was referenced Oct 13, 2024
Merged
Merged
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
@fauxpark @ilham-agustiawan
Separate RGBLight/RGB Matrix keycode handling (qmk#23679)
97a34e5 
* Separate RGBLight/RGB Matrix keycode handling

* Remove `_DISABLE_KEYCODES` handling

* Update RGB Matrix keycode docs

* Update underglow keycodes for previously migrated boards

* Update keycodes for boards with custom handling

* Fix typos

* Fix bad merge
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
@fauxpark @smallketchup82
Separate RGBLight/RGB Matrix keycode handling (qmk#23679)
b8a0287 
* Separate RGBLight/RGB Matrix keycode handling

* Remove `_DISABLE_KEYCODES` handling

* Update RGB Matrix keycode docs

* Update underglow keycodes for previously migrated boards

* Update keycodes for boards with custom handling

* Fix typos

* Fix bad merge
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
@fauxpark @jlaptavi
Separate RGBLight/RGB Matrix keycode handling (qmk#23679)
72d673f 
* Separate RGBLight/RGB Matrix keycode handling

* Remove `_DISABLE_KEYCODES` handling

* Update RGB Matrix keycode docs

* Update underglow keycodes for previously migrated boards

* Update keycodes for boards with custom handling

* Fix typos

* Fix bad merge
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@fauxpark @DmNosachev
Separate RGBLight/RGB Matrix keycode handling (qmk#23679)
1834ee9 
* Separate RGBLight/RGB Matrix keycode handling

* Remove `_DISABLE_KEYCODES` handling

* Update RGB Matrix keycode docs

* Update underglow keycodes for previously migrated boards

* Update keycodes for boards with custom handling

* Fix typos

* Fix bad merge
@VeyPatch VeyPatch mentioned this pull request Dec 10, 2024
Open
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@fauxpark @SyrupSplashin
Separate RGBLight/RGB Matrix keycode handling (qmk#23679)
ad12610 
* Separate RGBLight/RGB Matrix keycode handling

* Remove `_DISABLE_KEYCODES` handling

* Update RGB Matrix keycode docs

* Update underglow keycodes for previously migrated boards

* Update keycodes for boards with custom handling

* Fix typos

* Fix bad merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarlK90 KarlK90 KarlK90 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core develop-fast-track Intended to be merged early in the next develop cycle. documentation enhancement in progress keyboard keymap needs testing stale Issues or pull requests that have become inactive without resolution. via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fauxpark @KarlK90 @drashna @tzarc