Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keycodes for keyboards with RGB Matrix #24484

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Update keycodes for keyboards with RGB Matrix #24484

merged 2 commits into from
Nov 24, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Oct 13, 2024 •
edited
Loading

Description

This should essentially complete the splitting of the RGB_ keycodes into UG_ for RGBLight (Underglow) and RM_ for RGB Matrix, following on from #23679 and #23765 .

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team October 13, 2024 04:23
@fauxpark fauxpark requested a review from zvecr November 24, 2024 00:50
@zvecr zvecr merged commit f3bae56 into qmk:develop Nov 24, 2024
2 of 3 checks passed
@fauxpark fauxpark deleted the keyboard-rgb-matrix-keycodes branch November 24, 2024 15:58
VeyPatch added a commit to splitkb/qmk_firmware that referenced this pull request Nov 27, 2024
@VeyPatch
Update RGB keycodes (qmk#24484)
3a3105b
VeyPatch added a commit to splitkb/qmk_firmware that referenced this pull request Nov 27, 2024
@VeyPatch
Update RGB keycodes (qmk#24484)
0f234b4
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
@fauxpark @ilham-agustiawan
Update keycodes for keyboards with RGB Matrix (qmk#24484)
9f290ed
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
@fauxpark @smallketchup82
Update keycodes for keyboards with RGB Matrix (qmk#24484)
17c3e36
waffle87 pushed a commit that referenced this pull request Dec 2, 2024
@VeyPatch
[Keyboard] Add splitkb.com's Halcyon Kyria rev4 (#24512)
c8fe565 
* Add Halcyon Kyria Rev4

* Remove bootmagic and unused features

* Fix encoderindex

* Update readme.md

* Remove rgblight

* Implement requested changes

* Add encoder update user

* Remove rules.mk and add VIK configuration

* Move options to config.h

* Update RGB keycodes (#24484)

* implement changes

---------

Co-authored-by: harvey-splitkb <[email protected]>
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
@fauxpark @jlaptavi
Update keycodes for keyboards with RGB Matrix (qmk#24484)
c7c5301
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Dec 5, 2024
@VeyPatch @ilham-agustiawan
[Keyboard] Add splitkb.com's Halcyon Kyria rev4 (qmk#24512)
69da67b 
* Add Halcyon Kyria Rev4

* Remove bootmagic and unused features

* Fix encoderindex

* Update readme.md

* Remove rgblight

* Implement requested changes

* Add encoder update user

* Remove rules.mk and add VIK configuration

* Move options to config.h

* Update RGB keycodes (qmk#24484)

* implement changes

---------

Co-authored-by: harvey-splitkb <[email protected]>
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@fauxpark @DmNosachev
Update keycodes for keyboards with RGB Matrix (qmk#24484)
95b6c90
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@VeyPatch @DmNosachev
[Keyboard] Add splitkb.com's Halcyon Kyria rev4 (qmk#24512)
2116eae 
* Add Halcyon Kyria Rev4

* Remove bootmagic and unused features

* Fix encoderindex

* Update readme.md

* Remove rgblight

* Implement requested changes

* Add encoder update user

* Remove rules.mk and add VIK configuration

* Move options to config.h

* Update RGB keycodes (qmk#24484)

* implement changes

---------

Co-authored-by: harvey-splitkb <[email protected]>
eliseomartelli pushed a commit to eliseomartelli/qmk_firmware that referenced this pull request Dec 9, 2024
@VeyPatch @eliseomartelli
[Keyboard] Add splitkb.com's Halcyon Kyria rev4 (qmk#24512)
6c6739b 
* Add Halcyon Kyria Rev4

* Remove bootmagic and unused features

* Fix encoderindex

* Update readme.md

* Remove rgblight

* Implement requested changes

* Add encoder update user

* Remove rules.mk and add VIK configuration

* Move options to config.h

* Update RGB keycodes (qmk#24484)

* implement changes

---------

Co-authored-by: harvey-splitkb <[email protected]>
waffle87 pushed a commit to waffle87/qmk_firmware that referenced this pull request Dec 10, 2024
@VeyPatch @waffle87
[Keyboard] Add splitkb.com's Halcyon Kyria rev4 (qmk#24512)
cfb66ef 
* Add Halcyon Kyria Rev4

* Remove bootmagic and unused features

* Fix encoderindex

* Update readme.md

* Remove rgblight

* Implement requested changes

* Add encoder update user

* Remove rules.mk and add VIK configuration

* Move options to config.h

* Update RGB keycodes (qmk#24484)

* implement changes

---------

Co-authored-by: harvey-splitkb <[email protected]>
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@fauxpark @SyrupSplashin
Update keycodes for keyboards with RGB Matrix (qmk#24484)
f1b3a51
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@VeyPatch @SyrupSplashin
[Keyboard] Add splitkb.com's Halcyon Kyria rev4 (qmk#24512)
39c7f9e 
* Add Halcyon Kyria Rev4

* Remove bootmagic and unused features

* Fix encoderindex

* Update readme.md

* Remove rgblight

* Implement requested changes

* Add encoder update user

* Remove rules.mk and add VIK configuration

* Move options to config.h

* Update RGB keycodes (qmk#24484)

* implement changes

---------

Co-authored-by: harvey-splitkb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @zvecr