Backward compatibility for new RGB keycode handling #24490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daskygit
reviewed
Oct 30, 2024
Co-authored-by: Dasky <[email protected]>
daskygit
approved these changes
Oct 30, 2024
drashna
approved these changes
Nov 9, 2024
ilham-agustiawan
pushed a commit
to ilham-agustiawan/qmk_firmware
that referenced
this pull request
Nov 30, 2024
Co-authored-by: Dasky <[email protected]>
smallketchup82
pushed a commit
to smallketchup82/qmk_firmware
that referenced
this pull request
Dec 1, 2024
Co-authored-by: Dasky <[email protected]>
jlaptavi
pushed a commit
to jlaptavi/qmk_firmware
that referenced
this pull request
Dec 3, 2024
Co-authored-by: Dasky <[email protected]>
DmNosachev
pushed a commit
to DmNosachev/qmk_firmware
that referenced
this pull request
Dec 7, 2024
Co-authored-by: Dasky <[email protected]>
SyrupSplashin
pushed a commit
to SyrupSplashin/qmk_firmware
that referenced
this pull request
Dec 10, 2024
Co-authored-by: Dasky <[email protected]>
LeonMusCoden
pushed a commit
to LeonMusCoden/qmk_firmware
that referenced
this pull request
Jan 5, 2025
Co-authored-by: Dasky <[email protected]>
MichaelScofield45
pushed a commit
to MichaelScofield45/qmk_firmware
that referenced
this pull request
Jan 8, 2025
Co-authored-by: Dasky <[email protected]>
pashashocky
pushed a commit
to pashashocky/qmk
that referenced
this pull request
Jan 17, 2025
Co-authored-by: Dasky <[email protected]>
Rumadon
pushed a commit
to Rumadon/qmk_firmware
that referenced
this pull request
Jan 31, 2025
Co-authored-by: Dasky <[email protected]>
MaximumP
pushed a commit
to MaximumP/qmk_firmware
that referenced
this pull request
Feb 1, 2025
Co-authored-by: Dasky <[email protected]>
alinelena
pushed a commit
to alinelena/qmk_firmware
that referenced
this pull request
Feb 3, 2025
Co-authored-by: Dasky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial revert of #23679 to temporarily retain the current behaviour, where the
RGB_(nowUG_) keycodes also control RGB Matrix if it is enabled. A notice has been added to the RGBLight docs, advising users who don't want this simultaneous control of both features to use theRM_keycodes alongside theUG_ones, and add#define RGB_MATRIX_DISABLE_SHARED_KEYCODES(name slightly adjusted for clarity). All of the existing boards where this was (and is) applicable have been updated accordingly.Types of Changes
Issues Fixed or Closed by This PR
Checklist