Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pisces: correct layout macro reference in info.json #13410

Merged
merged 2 commits into from
Jul 3, 2021

Conversation

noroadsleft
Copy link
Member

Description

[title]

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr
Copy link
Member

zvecr commented Jul 2, 2021

☒ pisces: Claims to support a community layout that does not exist: split_3x6_1

Any chance you could also remove the LAYOUTS from rules.mk?

@noroadsleft
Copy link
Member Author

Any chance you could also remove the LAYOUTS from rules.mk?

Done.

@drashna drashna merged commit 79751f5 into qmk:master Jul 3, 2021
@noroadsleft noroadsleft deleted the cf/pisces branch July 3, 2021 23:08
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 4, 2021
…velop

* 'develop' of https://github.com/qmk/qmk_firmware: (37 commits)
  [Keyboard] Add CX60 (qmk#13402)
  Specskeys Configurator Bugfix and Refactor (qmk#13439)
  [Keyboard] IDOBAO ID67 (qmk#13378)
  [Keyboard] ortho boards from the technik gb (qmk#13382)
  [Keyboard] Add soldered variant of Titan 65 keyboard.  (qmk#13270)
  Pisces: correct layout macro reference in info.json (qmk#13410)
  [Keymap] Update Miryoku (qmk#13307)
  [Keyboard] Add wings42 keyboard (qmk#12734)
  [Keyboard] Added LAYOUT_60_iso_split_rshift to ok60 (qmk#12902)
  [Keymap] Jonavin merc additional encoder functionality (qmk#13039)
  [Bug] Pachi RGB - fix rgb placement (qmk#13428)
  AW20216 use register increment for framebuffer flushes (qmk#13430)
  Improve 'show_build_options' target (qmk#13425)
  [Keymap] gmmk pro keymap with numpad, enhanced encoder functionality and Win key lock (qmk#13406)
  [Keymap] Jonavin quefrency keymap add encoder functionality + 2tap Shift CAPSLOCK (qmk#13376)
  [Docs] RGB Matrix Caps Lock and Layer indicator example (qmk#13367)
  [Keymap] Add stanrc85 community layout (qmk#13338)
  [Keymap] 2Moons-JP Keymap Update (qmk#13279)
  [Keyboard] Added pistachio rev2 (qmk#13248)
  [Keymap] niclake - Keymap updates - Boardwalk updates & DZ60 create (qmk#13245)
  ...
jakeprime pushed a commit to jakeprime/qmk_firmware that referenced this pull request Jul 10, 2021
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants