Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IDOBAO ID67 #13378

Merged
merged 7 commits into from
Jul 4, 2021
Merged

Add IDOBAO ID67 #13378

merged 7 commits into from
Jul 4, 2021

Conversation

mehoron
Copy link
Contributor

@mehoron mehoron commented Jun 29, 2021 •
edited
Loading

Add the IDOBAO ID67 Keybaord

Description

This adds the IDOBAO ID67 keyboard.
It includes:

  • Layout
  • Default Keymap
  • VIA Keymap

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 29, 2021
@zvecr zvecr added the pr_checklist_pending Needs changes as per the PR checklist label Jun 29, 2021
sigprof
sigprof requested changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@sigprof sigprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code looks much like the output of kbfirmware.com (or some of its clones) — it uses obsolete functions, KEYMAP() instead of LAYOUT(), obsolete variables and comments in rules.mk, etc. If this is actually the case, instead of fixing all those issues manually, it would be much easier to redo the conversion using https://noroadsleft.github.io/kbf_qmk_converter/ — that converter generates files which actually use modern QMK conventions (and also formats the keymaps in a nicer way).

@ALowery
Update with modern conventions.
cfd792a 
 * Updated using https://noroadsleft.github.io/kbf_qmk_converter/
 * Fixed layouts.
 * Removed obsolete variables.
 * Fixed info.json
 * Updated rules.mk
 * Removed empty functions.
@mehoron
Copy link
Contributor Author

mehoron commented Jun 30, 2021

@sigprof Thanks for taking a look, I was indeed using some old keyboards as references. I've gone ahead and revamped everything to your suggestions as well as removed some empty functions that were bothering me. I compiled both keymaps and had the results tested as well.

@mehoron mehoron requested a review from sigprof June 30, 2021 17:24
drashna
drashna requested changes Jul 1, 2021
View reviewed changes
keyboards/id67/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/id67/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/id67/readme.md Outdated Show resolved Hide resolved
@mehoron
Copy link
Contributor Author

mehoron commented Jul 1, 2021

Thanks for taking a look @drashna I've committed your suggestions and made note of them for future projects.

@mehoron mehoron requested a review from drashna July 1, 2021 20:21
@fauxpark fauxpark requested a review from a team July 4, 2021 02:24
@fauxpark fauxpark removed the pr_checklist_pending Needs changes as per the PR checklist label Jul 4, 2021
@drashna drashna merged commit 3e04e22 into qmk:master Jul 4, 2021
@mehoron mehoron deleted the ID67_Include branch July 4, 2021 03:43
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 4, 2021
Merge branch 'develop' of https://github.com/qmk/qmk_firmware into de…
0e12685 
…velop

* 'develop' of https://github.com/qmk/qmk_firmware: (37 commits)
  [Keyboard] Add CX60 (qmk#13402)
  Specskeys Configurator Bugfix and Refactor (qmk#13439)
  [Keyboard] IDOBAO ID67 (qmk#13378)
  [Keyboard] ortho boards from the technik gb (qmk#13382)
  [Keyboard] Add soldered variant of Titan 65 keyboard.  (qmk#13270)
  Pisces: correct layout macro reference in info.json (qmk#13410)
  [Keymap] Update Miryoku (qmk#13307)
  [Keyboard] Add wings42 keyboard (qmk#12734)
  [Keyboard] Added LAYOUT_60_iso_split_rshift to ok60 (qmk#12902)
  [Keymap] Jonavin merc additional encoder functionality (qmk#13039)
  [Bug] Pachi RGB - fix rgb placement (qmk#13428)
  AW20216 use register increment for framebuffer flushes (qmk#13430)
  Improve 'show_build_options' target (qmk#13425)
  [Keymap] gmmk pro keymap with numpad, enhanced encoder functionality and Win key lock (qmk#13406)
  [Keymap] Jonavin quefrency keymap add encoder functionality + 2tap Shift CAPSLOCK (qmk#13376)
  [Docs] RGB Matrix Caps Lock and Layer indicator example (qmk#13367)
  [Keymap] Add stanrc85 community layout (qmk#13338)
  [Keymap] 2Moons-JP Keymap Update (qmk#13279)
  [Keyboard] Added pistachio rev2 (qmk#13248)
  [Keymap] niclake - Keymap updates - Boardwalk updates & DZ60 create (qmk#13245)
  ...
@mehoron mehoron mentioned this pull request Jul 5, 2021
Merged
6 tasks
jakeprime pushed a commit to jakeprime/qmk_firmware that referenced this pull request Jul 10, 2021
@mehoron @drashna
@ALowery @jakeprime
[Keyboard] IDOBAO ID67 (qmk#13378)
411039e 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Anthony Lowery <[email protected]>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@mehoron @drashna
@ALowery @HokieGeek
[Keyboard] IDOBAO ID67 (qmk#13378)
ccc675c 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Anthony Lowery <[email protected]>
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
@mehoron @drashna
@ALowery @wox
[Keyboard] IDOBAO ID67 (qmk#13378)
dd0a88f 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Anthony Lowery <[email protected]>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@mehoron @drashna
@ALowery @nhongooi
[Keyboard] IDOBAO ID67 (qmk#13378)
ec88698 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Anthony Lowery <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@sigprof sigprof Awaiting requested review from sigprof

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mehoron @sigprof @drashna @fauxpark @zvecr @ALowery