Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RGB Matrix Caps Lock and Layer indicator example #13367

Merged
merged 8 commits into from
Jul 3, 2021
Merged

RGB Matrix Caps Lock and Layer indicator example #13367

merged 8 commits into from
Jul 3, 2021

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented Jun 28, 2021 •
edited
Loading

Description

Provide some examples on using RGB Matrix as indicators, a frequently asked question on the QMK discord.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 29, 2021 01:30
drashna
drashna reviewed Jul 1, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer that both of these use the "advanced" function examples, as they're broken up into chunks for faster rendering

@filterpaper
Copy link
Contributor Author

Would prefer that both of these use the "advanced" function examples, as they're broken up into chunks for faster rendering

I've updated the function example as advised.

drashna
drashna reviewed Jul 1, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be better, given how the functions work, and what you're trying to do.

docs/feature_rgb_matrix.md Outdated Show resolved Hide resolved
docs/feature_rgb_matrix.md Outdated Show resolved Hide resolved
filterpaper and others added 2 commits July 2, 2021 08:16
@filterpaper @drashna
led min max change #1
d4acc8b 
Co-authored-by: Drashna Jaelre <[email protected]>
@filterpaper @drashna
led min max change #2
73b56c3 
Co-authored-by: Drashna Jaelre <[email protected]>
drashna
drashna approved these changes Jul 3, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@drashna drashna merged commit fdf71f1 into qmk:master Jul 3, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 4, 2021
Merge branch 'develop' of https://github.com/qmk/qmk_firmware into de…
0e12685 
…velop

* 'develop' of https://github.com/qmk/qmk_firmware: (37 commits)
  [Keyboard] Add CX60 (qmk#13402)
  Specskeys Configurator Bugfix and Refactor (qmk#13439)
  [Keyboard] IDOBAO ID67 (qmk#13378)
  [Keyboard] ortho boards from the technik gb (qmk#13382)
  [Keyboard] Add soldered variant of Titan 65 keyboard.  (qmk#13270)
  Pisces: correct layout macro reference in info.json (qmk#13410)
  [Keymap] Update Miryoku (qmk#13307)
  [Keyboard] Add wings42 keyboard (qmk#12734)
  [Keyboard] Added LAYOUT_60_iso_split_rshift to ok60 (qmk#12902)
  [Keymap] Jonavin merc additional encoder functionality (qmk#13039)
  [Bug] Pachi RGB - fix rgb placement (qmk#13428)
  AW20216 use register increment for framebuffer flushes (qmk#13430)
  Improve 'show_build_options' target (qmk#13425)
  [Keymap] gmmk pro keymap with numpad, enhanced encoder functionality and Win key lock (qmk#13406)
  [Keymap] Jonavin quefrency keymap add encoder functionality + 2tap Shift CAPSLOCK (qmk#13376)
  [Docs] RGB Matrix Caps Lock and Layer indicator example (qmk#13367)
  [Keymap] Add stanrc85 community layout (qmk#13338)
  [Keymap] 2Moons-JP Keymap Update (qmk#13279)
  [Keyboard] Added pistachio rev2 (qmk#13248)
  [Keymap] niclake - Keymap updates - Boardwalk updates & DZ60 create (qmk#13245)
  ...
jakeprime pushed a commit to jakeprime/qmk_firmware that referenced this pull request Jul 10, 2021
@filterpaper @fauxpark
@drashna @jakeprime
[Docs] RGB Matrix Caps Lock and Layer indicator example (qmk#13367)
7292e7c 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: filterpaper <filterpaper@localhost>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@filterpaper @fauxpark
@drashna @HokieGeek
[Docs] RGB Matrix Caps Lock and Layer indicator example (qmk#13367)
d44d196 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: filterpaper <filterpaper@localhost>
@filterpaper filterpaper deleted the rgbmatrix-indicator-examples branch July 23, 2021 01:35
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
@filterpaper @fauxpark
@drashna @wox
[Docs] RGB Matrix Caps Lock and Layer indicator example (qmk#13367)
15e4eba 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: filterpaper <filterpaper@localhost>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@filterpaper @fauxpark
@drashna @nhongooi
[Docs] RGB Matrix Caps Lock and Layer indicator example (qmk#13367)
5fec27e 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: filterpaper <filterpaper@localhost>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@filterpaper @fauxpark @drashna
[Docs] RGB Matrix Caps Lock and Layer indicator example (qmk#13367)
6980ff8 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: filterpaper <filterpaper@localhost>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @drashna @fauxpark