Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add Yugo-M Controller #10389

Merged
merged 36 commits into from
Oct 4, 2020
Merged

[Keyboard] Add Yugo-M Controller #10389

merged 36 commits into from
Oct 4, 2020

Conversation

tomic1785
Copy link
Contributor

Description

Yugo-M is an ARM-based replacement controller for IBM Model M keyboards.
To my knowledge, there aren't any products of the same kind available for purchase at this time, which are supported by QMK Firmware.
Check out the project repo

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Nidzo Tomic and others added 22 commits June 26, 2020 18:44
zvecr
zvecr requested changes Sep 22, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the halconf,chconf,mcuconf should follow the new strategy per https://github.com/qmk/qmk_firmware/tree/master/keyboards/planck/rev6. Where only the required differences are changed, and otherwise rely on the absence of the file to use the defaults.

keyboards/yugo_m/model_m_101/config.h Outdated Show resolved Hide resolved
keyboards/yugo_m/model_m_101/model_m_101.c Outdated Show resolved Hide resolved
keyboards/yugo_m/model_m_101/model_m_101.h Outdated Show resolved Hide resolved
keyboards/yugo_m/model_m_101/rules.mk Outdated Show resolved Hide resolved
keyboards/yugo_m/model_m_101/model_m_101.c Outdated Show resolved Hide resolved
@zvecr zvecr added the keyboard label Sep 22, 2020
@zvecr zvecr requested a review from a team September 22, 2020 23:27
noroadsleft
noroadsleft approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft requested a review from a team September 23, 2020 22:03
fauxpark
fauxpark requested changes Sep 24, 2020
View reviewed changes
keyboards/yugo_m/model_m_101/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/yugo_m/model_m_101/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/yugo_m/model_m_101/model_m_101.c Outdated Show resolved Hide resolved
@tomic1785 tomic1785 requested review from fauxpark and zvecr September 25, 2020 15:18
zvecr
zvecr requested changes Oct 1, 2020
View reviewed changes
keyboards/yugo_m/model_m_101/model_m_101.c Outdated Show resolved Hide resolved
@zvecr zvecr self-requested a review October 1, 2020 23:34
@drashna drashna merged commit edebe56 into qmk:master Oct 4, 2020
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Oct 7, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
15be960 
* 'master' of https://github.com/qmk/qmk_firmware: (178 commits)
  Docs: fix udev rules
  [CLI] Add c2json (qmk#8817)
  Improve LAYOUT macro searching (qmk#9530)
  CLI: update subcommands to use return instead of exit() (qmk#10323)
  Fixes small typo in docs (qmk#10515)
  Update personal keymap for Let's Split keyboard. (qmk#10536)
  [Keymap] Move my custom functions and keymaps to userspace (qmk#10502)
  [Keyboard] add support for ymd75 rev3 (qmk#10483)
  [Keyboard] Add soy20 PCB (qmk#10440)
  Fix for MIDI sustain effect issue (qmk#10361)
  format code according to conventions [skip ci]
  [Keyboard] Add Yugo-M Controller (qmk#10389)
  [Keymap] Add onekey keymap for OLED testing (qmk#10380)
  [Keymap] Add winterNebs keymaps  (qmk#10328)
  [Keymap] Added 333fred 5x6_5 keymap (qmk#10272)
  [Keyboard] Add hannah60rgb rev.2 PCB (qmk#10287)
  Adding VIA support to katana60 rev2 (qmk#10442)
  OLED driver fixes (qmk#10377)
  IS31FL3741 driver fixup (qmk#10519)
  add info.json for XD75 keyboard (qmk#10523)
  ...
barrettclark pushed a commit to barrettclark/qmk_firmware that referenced this pull request Oct 8, 2020
Merge remote-tracking branch 'upstream/master' into master
5a529c4 
* upstream/master: (81 commits)
  [Keyboard] New keyboard - eiri (qmk#10529)
  [Keymap] Add niu mini dye sub keymap (qmk#10525)
  Clean ChibiOS platform files (qmk#10505)
  [Keyboard] LeftyNumpad Keyboard (qmk#10500)
  [Keyboard] add maja capslock indicator (qmk#10151)
  Fix issue introduced by PR#10404 (qmk#10559)
  Docs: fix udev rules
  [CLI] Add c2json (qmk#8817)
  Improve LAYOUT macro searching (qmk#9530)
  CLI: update subcommands to use return instead of exit() (qmk#10323)
  Fixes small typo in docs (qmk#10515)
  Update personal keymap for Let's Split keyboard. (qmk#10536)
  [Keymap] Move my custom functions and keymaps to userspace (qmk#10502)
  [Keyboard] add support for ymd75 rev3 (qmk#10483)
  [Keyboard] Add soy20 PCB (qmk#10440)
  Fix for MIDI sustain effect issue (qmk#10361)
  format code according to conventions [skip ci]
  [Keyboard] Add Yugo-M Controller (qmk#10389)
  [Keymap] Add onekey keymap for OLED testing (qmk#10380)
  [Keymap] Add winterNebs keymaps  (qmk#10328)
  ...
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@tomic1785 @zvecr
@noroadsleft @fauxpark
[Keyboard] Add Yugo-M Controller (qmk#10389)
3f1d385 
* Created folder structure and blank files

* Update the yugo_m initial blank files

* Add yugo_m default keymap

* Update yugo_m info.json

* Fix yugo_m keymap.c

* keymap.c update

* Changed subfolder name

* File names

* Fixed lock LEDs problem

* Returned old subfolder name; LEDs fix

* Activated anti-ghosting feature in config.h

* Update readme.md

* Changed LAYOUT to LAYOUT_all

* Updated keymap.c

* corrected LAYOUT to LAYOUT_all in info.json

* Rewritten readme.md according to the template

* Removed backslashes from keymap.c

* Fixed readme.md

* Fixed readme.md again

* Tidying up readme.md

* Tidying up comments and readme.md

* Removed a line from rules.mk

* Update keyboards/yugo_m/model_m_101/model_m_101.h

Co-authored-by: Joel Challis <[email protected]>

* Removed chconf, halconf, mcuconf

* Updated LED control

* Update keyboards/yugo_m/model_m_101/rules.mk

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/yugo_m/model_m_101/config.h

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/yugo_m/model_m_101/config.h

Co-authored-by: James Young <[email protected]>

* Update keyboards/yugo_m/model_m_101/config.h

Co-authored-by: James Young <[email protected]>

* Update keyboards/yugo_m/model_m_101/model_m_101.c

Co-authored-by: James Young <[email protected]>

* Update keyboards/yugo_m/readme.md

Co-authored-by: James Young <[email protected]>

* Updated readme.md, there was an outdated info

* Update keyboards/yugo_m/model_m_101/keymaps/default/keymap.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/yugo_m/model_m_101/keymaps/default/keymap.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/yugo_m/model_m_101/model_m_101.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/yugo_m/model_m_101/model_m_101.c

Co-authored-by: Joel Challis <[email protected]>

Co-authored-by: Nidzo Tomic <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: Ryan <[email protected]>
oscarcarlsson pushed a commit to oscarcarlsson/qmk_firmware that referenced this pull request Nov 2, 2020
@tomic1785 @zvecr
@noroadsleft @fauxpark
[Keyboard] Add Yugo-M Controller (qmk#10389)
e8488ec 
* Created folder structure and blank files

* Update the yugo_m initial blank files

* Add yugo_m default keymap

* Update yugo_m info.json

* Fix yugo_m keymap.c

* keymap.c update

* Changed subfolder name

* File names

* Fixed lock LEDs problem

* Returned old subfolder name; LEDs fix

* Activated anti-ghosting feature in config.h

* Update readme.md

* Changed LAYOUT to LAYOUT_all

* Updated keymap.c

* corrected LAYOUT to LAYOUT_all in info.json

* Rewritten readme.md according to the template

* Removed backslashes from keymap.c

* Fixed readme.md

* Fixed readme.md again

* Tidying up readme.md

* Tidying up comments and readme.md

* Removed a line from rules.mk

* Update keyboards/yugo_m/model_m_101/model_m_101.h

Co-authored-by: Joel Challis <[email protected]>

* Removed chconf, halconf, mcuconf

* Updated LED control

* Update keyboards/yugo_m/model_m_101/rules.mk

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/yugo_m/model_m_101/config.h

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/yugo_m/model_m_101/config.h

Co-authored-by: James Young <[email protected]>

* Update keyboards/yugo_m/model_m_101/config.h

Co-authored-by: James Young <[email protected]>

* Update keyboards/yugo_m/model_m_101/model_m_101.c

Co-authored-by: James Young <[email protected]>

* Update keyboards/yugo_m/readme.md

Co-authored-by: James Young <[email protected]>

* Updated readme.md, there was an outdated info

* Update keyboards/yugo_m/model_m_101/keymaps/default/keymap.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/yugo_m/model_m_101/keymaps/default/keymap.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/yugo_m/model_m_101/model_m_101.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/yugo_m/model_m_101/model_m_101.c

Co-authored-by: Joel Challis <[email protected]>

Co-authored-by: Nidzo Tomic <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomic1785 @drashna @fauxpark @zvecr @noroadsleft