Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IS31FL3741 driver fixup #10519

Merged
merged 4 commits into from
Oct 3, 2020
Merged

IS31FL3741 driver fixup #10519

merged 4 commits into from
Oct 3, 2020

Conversation

elfmimi
Copy link
Contributor

@elfmimi elfmimi commented Oct 3, 2020 •
edited
Loading

Description

Fix up a few things about IS31FL3741 driver.

  • Fix issue with data transfer of CS1_SW7 to CS18_SW7. 0e40e9e
  • Fix issue with handling of scaling register buffer's dirty flag. 05731f1
  • Remove unused extern declaration. f792491
  • Compaction of struct is31_led utilizing bit fields. 46538d9

Types of Changes

  • Core
  • Driver
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark reviewed Oct 3, 2020
View reviewed changes
drivers/issi/is31fl3741.h Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team October 3, 2020 09:59
@tzarc tzarc merged commit 1fe7743 into qmk:master Oct 3, 2020
@elfmimi
Copy link
Contributor Author

elfmimi commented Oct 4, 2020

Thank you for reviewing, as always. @fauxpark @tzarc

Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Oct 7, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
15be960 
* 'master' of https://github.com/qmk/qmk_firmware: (178 commits)
  Docs: fix udev rules
  [CLI] Add c2json (qmk#8817)
  Improve LAYOUT macro searching (qmk#9530)
  CLI: update subcommands to use return instead of exit() (qmk#10323)
  Fixes small typo in docs (qmk#10515)
  Update personal keymap for Let's Split keyboard. (qmk#10536)
  [Keymap] Move my custom functions and keymaps to userspace (qmk#10502)
  [Keyboard] add support for ymd75 rev3 (qmk#10483)
  [Keyboard] Add soy20 PCB (qmk#10440)
  Fix for MIDI sustain effect issue (qmk#10361)
  format code according to conventions [skip ci]
  [Keyboard] Add Yugo-M Controller (qmk#10389)
  [Keymap] Add onekey keymap for OLED testing (qmk#10380)
  [Keymap] Add winterNebs keymaps  (qmk#10328)
  [Keymap] Added 333fred 5x6_5 keymap (qmk#10272)
  [Keyboard] Add hannah60rgb rev.2 PCB (qmk#10287)
  Adding VIA support to katana60 rev2 (qmk#10442)
  OLED driver fixes (qmk#10377)
  IS31FL3741 driver fixup (qmk#10519)
  add info.json for XD75 keyboard (qmk#10523)
  ...
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@elfmimi
IS31FL3741 driver fixup (qmk#10519)
0743096 
* Fix issue with data transfer of CS1_SW7 to CS18_SW7.

* Fix issue with handling of scaling register buffer's dirty flag.

* Remove unused extern declaration.

* Compaction of struct is31_led utilizing bit fields.
oscarcarlsson pushed a commit to oscarcarlsson/qmk_firmware that referenced this pull request Nov 2, 2020
@elfmimi
IS31FL3741 driver fixup (qmk#10519)
5429e95 
* Fix issue with data transfer of CS1_SW7 to CS18_SW7.

* Fix issue with handling of scaling register buffer's dirty flag.

* Remove unused extern declaration.

* Compaction of struct is31_led utilizing bit fields.
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Nov 24, 2020
@elfmimi @drashna
IS31FL3741 driver fixup (qmk#10519)
cbdc5b9 
* Fix issue with data transfer of CS1_SW7 to CS18_SW7.

* Fix issue with handling of scaling register buffer's dirty flag.

* Remove unused extern declaration.

* Compaction of struct is31_led utilizing bit fields.
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 13, 2021
@elfmimi @drashna
IS31FL3741 driver fixup (qmk#10519)
3b36ad0 
* Fix issue with data transfer of CS1_SW7 to CS18_SW7.

* Fix issue with handling of scaling register buffer's dirty flag.

* Remove unused extern declaration.

* Compaction of struct is31_led utilizing bit fields.
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@elfmimi
IS31FL3741 driver fixup (qmk#10519)
2bf84b7 
* Fix issue with data transfer of CS1_SW7 to CS18_SW7.

* Fix issue with handling of scaling register buffer's dirty flag.

* Remove unused extern declaration.

* Compaction of struct is31_led utilizing bit fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elfmimi @tzarc @fauxpark