LeftyNumpad Keyboard #10500
Merged
LeftyNumpad Keyboard #10500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the noise on the PR, seems there was a minor conflict between how the tests ran and how the make process worked.
|
zvecr
requested changes
Oct 1, 2020
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
fauxpark
requested changes
Oct 3, 2020
Erovia
reviewed
Oct 3, 2020
noroadsleft
requested changes
Oct 3, 2020
Co-authored-by: James Young <[email protected]> Co-authored-by: Ryan <[email protected]>
|
Thanks all for the feedback. There were a lot of items here which I didn't consider and seemed to be glossed over in the PR guide. If you feel it's appropriate, I would be more than happy to make a PR to those docs as well to fill out the documentation there. |
drashna
approved these changes
Oct 4, 2020
fauxpark
requested changes
Oct 7, 2020
Co-authored-by: Ryan <[email protected]>
fauxpark
approved these changes
Oct 7, 2020
barrettclark
pushed a commit
to barrettclark/qmk_firmware
that referenced
this pull request
Oct 8, 2020
* upstream/master: (81 commits) [Keyboard] New keyboard - eiri (qmk#10529) [Keymap] Add niu mini dye sub keymap (qmk#10525) Clean ChibiOS platform files (qmk#10505) [Keyboard] LeftyNumpad Keyboard (qmk#10500) [Keyboard] add maja capslock indicator (qmk#10151) Fix issue introduced by PR#10404 (qmk#10559) Docs: fix udev rules [CLI] Add c2json (qmk#8817) Improve LAYOUT macro searching (qmk#9530) CLI: update subcommands to use return instead of exit() (qmk#10323) Fixes small typo in docs (qmk#10515) Update personal keymap for Let's Split keyboard. (qmk#10536) [Keymap] Move my custom functions and keymaps to userspace (qmk#10502) [Keyboard] add support for ymd75 rev3 (qmk#10483) [Keyboard] Add soy20 PCB (qmk#10440) Fix for MIDI sustain effect issue (qmk#10361) format code according to conventions [skip ci] [Keyboard] Add Yugo-M Controller (qmk#10389) [Keymap] Add onekey keymap for OLED testing (qmk#10380) [Keymap] Add winterNebs keymaps (qmk#10328) ...
kjganz
pushed a commit
to kjganz/qmk_firmware
that referenced
this pull request
Oct 28, 2020
* Clean LeftyNumpad code * Fix typo in recently renamed file * Fix issues with keymap layout * Initial PR Feedback fixes * Update keyboards/handwired/leftynumpad/config.h Co-authored-by: Joel Challis <[email protected]> * Update keyboards/handwired/leftynumpad/config.h Co-authored-by: Joel Challis <[email protected]> * Apply suggestions from code review Co-authored-by: Joel Challis <[email protected]> * Apply suggestions from code review Co-authored-by: James Young <[email protected]> Co-authored-by: Ryan <[email protected]> * Add fixes based on PR feedback * Update keyboards/handwired/leftynumpad/readme.md Co-authored-by: Ryan <[email protected]> Co-authored-by: Joel Challis <[email protected]> Co-authored-by: James Young <[email protected]> Co-authored-by: Ryan <[email protected]>
oscarcarlsson
pushed a commit
to oscarcarlsson/qmk_firmware
that referenced
this pull request
Nov 2, 2020
* Clean LeftyNumpad code * Fix typo in recently renamed file * Fix issues with keymap layout * Initial PR Feedback fixes * Update keyboards/handwired/leftynumpad/config.h Co-authored-by: Joel Challis <[email protected]> * Update keyboards/handwired/leftynumpad/config.h Co-authored-by: Joel Challis <[email protected]> * Apply suggestions from code review Co-authored-by: Joel Challis <[email protected]> * Apply suggestions from code review Co-authored-by: James Young <[email protected]> Co-authored-by: Ryan <[email protected]> * Add fixes based on PR feedback * Update keyboards/handwired/leftynumpad/readme.md Co-authored-by: Ryan <[email protected]> Co-authored-by: Joel Challis <[email protected]> Co-authored-by: James Young <[email protected]> Co-authored-by: Ryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new handwired keypad
Types of Changes
Checklist