Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Drakon #10071

Merged
merged 39 commits into from
Aug 23, 2020
Merged

Add Drakon #10071

merged 39 commits into from
Aug 23, 2020

Conversation

JagdPietr
Copy link
Contributor

@JagdPietr JagdPietr commented Aug 17, 2020 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@JagdPietr JagdPietr changed the title drakon add drakon Aug 17, 2020
@JagdPietr JagdPietr changed the title add drakon Add Drakon Aug 17, 2020
zvecr
zvecr requested changes Aug 18, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you give the PR checklist another pass.

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team August 18, 2020 23:49
noroadsleft
noroadsleft requested changes Aug 19, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub tip: You can apply multiple suggestions to a single commit by using the Files Changed tab.

keyboards/drakon/info.json Outdated Show resolved Hide resolved
keyboards/drakon/info.json Outdated Show resolved Hide resolved
keyboards/drakon/info.json Outdated Show resolved Hide resolved
keyboards/drakon/config.h Outdated Show resolved Hide resolved
keyboards/drakon/config.h Outdated Show resolved Hide resolved
keyboards/drakon/keymaps/logo/keymap.c Outdated Show resolved Hide resolved
keyboards/drakon/keymaps/logo/readme.md Outdated Show resolved Hide resolved
keyboards/drakon/keymaps/wkl/keymap.c Outdated Show resolved Hide resolved
keyboards/drakon/config.h Outdated Show resolved Hide resolved
keyboards/drakon/config.h Outdated Show resolved Hide resolved
JagdPietr and others added 16 commits August 19, 2020 17:05
@JagdPietr @noroadsleft
Update keyboards/drakon/info.json
29e327b 
Co-authored-by: James Young <[email protected]>
@JagdPietr @noroadsleft
Update keyboards/drakon/info.json
cb94396 
Co-authored-by: James Young <[email protected]>
@JagdPietr @noroadsleft
Update keyboards/drakon/info.json
5780b64 
Co-authored-by: James Young <[email protected]>
@JagdPietr @noroadsleft
Update keyboards/drakon/config.h
91e7040 
Co-authored-by: James Young <[email protected]>
@JagdPietr @noroadsleft
Update keyboards/drakon/config.h
de8a6c7 
Co-authored-by: James Young <[email protected]>
@JagdPietr @noroadsleft
Update keyboards/drakon/rules.mk
96c35a7 
Co-authored-by: James Young <[email protected]>
@JagdPietr @noroadsleft
Update keyboards/drakon/rules.mk
7682a9d 
Co-authored-by: James Young <[email protected]>
@JagdPietr @noroadsleft
Update keyboards/drakon/rules.mk
3dd98d1 
Co-authored-by: James Young <[email protected]>
@JagdPietr @noroadsleft
Update keyboards/drakon/rules.mk
0ebcb13 
Co-authored-by: James Young <[email protected]>
@JagdPietr @noroadsleft
Update keyboards/drakon/keymaps/wkl/readme.md
eca07bd 
Co-authored-by: James Young <[email protected]>
@JagdPietr @noroadsleft
Update keyboards/drakon/keymaps/logo/keymap.c
562252d 
Co-authored-by: James Young <[email protected]>
@JagdPietr @noroadsleft
Update keyboards/drakon/keymaps/default/keymap.c
2ee47e2 
Co-authored-by: James Young <[email protected]>
@JagdPietr @noroadsleft
Update keyboards/drakon/keymaps/wkl/keymap.c
ce30287 
Co-authored-by: James Young <[email protected]>
@JagdPietr @noroadsleft
Update keyboards/drakon/config.h
c6a350a 
Co-authored-by: James Young <[email protected]>
@JagdPietr @noroadsleft
Update keyboards/drakon/config.h
72a75cf 
Co-authored-by: James Young <[email protected]>
@JagdPietr @noroadsleft
Update keyboards/drakon/keymaps/logo/readme.md
4d3c71d 
Co-authored-by: James Young <[email protected]>
noroadsleft
noroadsleft requested changes Aug 19, 2020
View reviewed changes
keyboards/drakon/config.h Outdated Show resolved Hide resolved
keyboards/drakon/readme.md Outdated Show resolved Hide resolved
keyboards/drakon/rules.mk Outdated Show resolved Hide resolved
noroadsleft
noroadsleft requested changes Aug 22, 2020
View reviewed changes
keyboards/drakon/config.h Show resolved Hide resolved
keyboards/drakon/keymaps/wkl/keymap.c Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Aug 22, 2020
View reviewed changes
keyboards/drakon/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/drakon/keymaps/wkl/keymap.c Outdated Show resolved Hide resolved
noroadsleft
noroadsleft approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit 92da1f0 into qmk:master Aug 23, 2020
@noroadsleft
Copy link
Member

Thanks!

@JagdPietr
Copy link
Contributor Author

Thank you very nuch for looking through all of these! Such great people :)

@JagdPietr JagdPietr mentioned this pull request Sep 1, 2020
Merged
14 tasks
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
@JagdPietr @nicocesar
[Keyboard] Drakon (qmk#10071)
dbc41ad 
* Drakon60

* Updates

* Update: Deletion of XXX in WKL keymap

* Update keymap.c

* Revert "Updates"

This reverts commit b4f97d3.

* Update keyboards/drakon/info.json

* Update keyboards/drakon/info.json

* Update keyboards/drakon/info.json

* Update keyboards/drakon/config.h

* Update keyboards/drakon/config.h

* Update keyboards/drakon/rules.mk

* Update keyboards/drakon/rules.mk

* Update keyboards/drakon/rules.mk

* Update keyboards/drakon/rules.mk

* Update keyboards/drakon/keymaps/wkl/readme.md

* Update keyboards/drakon/keymaps/logo/keymap.c

* Update keyboards/drakon/keymaps/default/keymap.c

* Update keyboards/drakon/keymaps/wkl/keymap.c

* Update keyboards/drakon/config.h

* Update keyboards/drakon/config.h

* Update keyboards/drakon/keymaps/logo/readme.md

* Update keyboards/drakon/config.h

* Update keyboards/drakon/readme.md

* Update keyboards/drakon/rules.mk

* Update keyboards/drakon/drakon.c

* Update config.h

Deletion as recommended

* Update config.h

Correction of the deletion

* Update config.h

Deletion of line as recommended

* Update config.h

Deleted line as recommended

* Update keymap.c

Deleted line as recommended

* Deletion of File

* Delete config.h

* Delete config.h

* Delete config.h

* Update keyboards/drakon/config.h

* Update keyboards/drakon/keymaps/wkl/keymap.c

* Update keyboards/drakon/keymaps/default/keymap.c

* Update keyboards/drakon/keymaps/wkl/keymap.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JagdPietr @noroadsleft @fauxpark @zvecr @ridingqwerty