Drakon updates 2

[JagdPietr]

Description

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[JagdPietr]

Updates in this PR:

1. Transfer of drakon to jagdpietr dir
2. Fix of encoder switch placement and orientation
3. Transfer of OLED stuff from keymap(s).c to keyboard.c for OLED functionality
4. Deletion of logo keymap (unusable keymap due to OLED functionality being moved to keyboard.c)

[noroadsleft]

This branch needs to be rebased upon QMK's current master branch. As you've already added this board in #10071, what this PR would do when merged is add a duplicate under a new folder, instead of moving the existing files (modified or not) to the new folder.

To sort this properly, you should resynchronize your master branch, then run the following commands:

# check out this branch:
git checkout drakon-updates-2

# rewrite this branch to match the now-synchronized master:
git reset --hard master

# create the jagdpietr directory, which won't exist at this point:
mkdir -p keyboards/jagdpietr/

# move the keyboard source files:
git mv -- keyboards/drakon/ keyboards/jagdpietr/drakon/

# remove the logo keymap, which I notice isn't present here:
git rm -rf -- keyboards/jagdpietr/drakon/keymaps/logo/

# commit the changes:
git commit -m "move Drakon to jagdpietr directory"

# update this pull request:
git push --force-with-lease

[JagdPietr]

This branch needs to be rebased upon QMK's current master branch. As you've already added this board in #10071, what this PR would do when merged is add a duplicate under a new folder, instead of moving the existing files (modified or not) to the new folder.

To sort this properly, you should resynchronize your master branch, then run the following commands:

# check out this branch:
git checkout drakon-updates-2

# rewrite this branch to match the now-synchronized master:
git reset --hard master

# create the jagdpietr directory, which won't exist at this point:
mkdir -p keyboards/jagdpietr/

# move the keyboard source files:
git mv -- keyboards/drakon/ keyboards/jagdpietr/drakon/

# remove the logo keymap, which I notice isn't present here:
git rm -rf -- keyboards/jagdpietr/drakon/keymaps/logo/

# commit the changes:
git commit -m "move Drakon to jagdpietr directory"

# update this pull request:
git push --force-with-lease

noted and finished the instructions
thank you very much!

[noroadsleft]

@JagdPietr Your resynchronization wasn't done properly; there should only be one commit on this PR.

[JagdPietr]

I apologize for that; will redo this action

[JagdPietr]

Finished with the instructions already, and I hope this is correct this time.
However, I'm quite worried because the changes on keyboard.c and keymap/s.c were not reflected on this latest commit when I viewed them.

[drashna]

Yeah, the changes don't seem to be reflected, unfortunately. :(

[noroadsleft]

Also, the changes to lib/vusb/ need to be reverted:

From your qmk_firmware directory, run:

cd lib/vusb/
git checkout bdb53e4c043d089279d9891b68bea77614cb97ee
cd ../../
git add -- lib/vusb/
git commit -m "fix vusb submodule"
git push

[JagdPietr]

Changes and recommendations finished - I just hope I got them all correct :)

[JagdPietr]

Hi! May I ask what should I do to finish this PR? It has taken a bit while now, and maybe I missed something to do to finish this PR.

[noroadsleft]

I don't recall if it was asked, but are there any of these in the wild?

[JagdPietr]

I have two working prototypes in my care, and another in the proxy. The GB is still on production phase.

[noroadsleft]

Ah, wanted to make sure we're not messing things up for end users if we move this now.

[noroadsleft]

Thanks!

[JagdPietr]

Thank you very much for all of you! Such a great team :)