ENH: suports wiring up q2-diversity's alpha, beta, a/b_phylo, and a/b_rarefaction #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LINT: removes unneeded comment LINT: removes unused comment, print stmt
ChrisKeefe
changed the title
thermokarst
suggested changes
Aug 16, 2020
There was a problem hiding this comment.
Lookin' good @ChrisKeefe! A handful of minor comments and suggestions. Please let me know if you have any questions.
- METRIC collection cleanup - style corrections - hardcodes canberra-adkinsd test vals
|
Sorry these review-comment commits are broken up a little funny, @thermokarst. Github hid a bunch of "additional comments" when I did my first pass, and I'm disinclined to re-organize these and force-push. Unless I misinterpreted the one unresolved comment, this should address everything. |
ChrisKeefe
commented
Aug 19, 2020
q2_diversity_lib/tests/test_beta.py
Outdated
| @@ -337,7 +337,6 @@ class BetaPassthroughTests(TestPluginBase): | |||
| def setUp(self): | |||
| super().setUp() | |||
| self.method = self.plugin.actions['beta_passthrough'] | |||
| beta.METRICS['NONPHYLO']['UNIMPL'] = beta.METRICS['NONPHYLO']['UNIMPL'] | |||
There was a problem hiding this comment.
Thanks for catching this!
ChrisKeefe
commented
Aug 19, 2020
thermokarst
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22, required by qiime2/q2-diversity#280
Supersedes and closes #21
See also qiime2/q2-diversity#281
54702b4 closes qiime2/q2-diversity#286
54702b4 closes qiime2/q2-diversity#288
4aa2ff7 closes qiime2/q2-diversity#255