ENH: Route all diversity calculations through diversity-lib #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will cause test failures in CI until div-lib PR qiime2#21 is merged
…hylogenetic metrics
|
This tests clean locally, but tests will continue to fail here until qiime2/q2-diversity-lib#21 is merged. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
thermokarst
suggested changes
Aug 16, 2020
thermokarst
approved these changes
Aug 19, 2020
|
Going to merge now - travis is failing because the staging env is missing the latest div-lib. I tested locally and all seems in order, no need to wait 2-3 hrs for the new env. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #280.
See also qiime2/q2-diversity-lib#21
Closes #284.
Note: Renames "weighted_unifrac" to "weighted_unnormalized_unifrac", aligningq2-diversitywithq2-diversity-liband the underlyingunifracpackage. This is a breaking API change.