Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Route all alpha and beta diversity calculations through q2-diversity-lib #280

Closed
ChrisKeefe opened this issue Jun 25, 2020 · 1 comment · Fixed by #281
Closed

ENH: Route all alpha and beta diversity calculations through q2-diversity-lib #280

ChrisKeefe opened this issue Jun 25, 2020 · 1 comment · Fixed by #281

Comments

@ChrisKeefe
Copy link
Collaborator

Improvement Description
The following Actions should be made into Pipelines, dependent on Actions from q2-diversity-lib:

  • alpha
  • alpha phylogenetic
  • beta
  • beta phylogenetic

q2-diversity-lib, in turn, will dispatch these calls to the best available implementation of the requested method. See qiime2/q2-diversity-lib#22

Current Behavior
core-metrics and core-metrics-phylogenetic call methods from q2-diversity-lib for alpha and beta diversity calculations.
The alpha and beta Actions, however, are called directly from q2-diversity.

This proposal makes q2-diversity-lib uniquely responsible for determining what implementation of a given method should be used. This allows q2-diversity to stop caring about what methods have been implemented/constrained in q2-diversity-lib at any given moment, and which methods will simply be passed through to an appropriate dependency.

Proposed Behavior

Comments

  1. This will likely require minor changes to other Actions that use these functions - e.g. alpha_phylogenetic
@thermokarst
Copy link
Contributor

Please see #281 (comment) for some modifications to this plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants