Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced public visibility of interfaced implementations #117

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

pyrocumulus
Copy link
Owner

Also sealed most of the internal classes where applicable.

Closes #71

Also sealed most of the internal classes where applicable
Closes #71
@pyrocumulus pyrocumulus added api breaking change This issue or pull request will result in a breaking change code quality Improves unit testing, code coverage and/or reduces dead code labels Mar 17, 2022
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #117 (b95b67f) into develop (559377f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #117   +/-   ##
========================================
  Coverage    99.50%   99.50%           
========================================
  Files          116      116           
  Lines         2212     2212           
  Branches       144      144           
========================================
  Hits          2201     2201           
  Misses           4        4           
  Partials         7        7           

@pyrocumulus pyrocumulus merged commit 86d2514 into develop Mar 17, 2022
@pyrocumulus pyrocumulus deleted the decrease-visibility branch March 17, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api breaking change This issue or pull request will result in a breaking change code quality Improves unit testing, code coverage and/or reduces dead code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decrease visibility of public types
1 participant