Reduced public visibility of interfaced implementations (#117)

* Reduced public visibility of interfaced implementations
* Also sealed most of the internal classes where applicable

Closes #71

CHANGELOG.md

@@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 ### Changed
 
 - **BREAKING**: Removed add batch output from API. Please use the `AddOutputsAsync` method from now on. This is donation only. [#78](https://github.com/pyrocumulus/pvoutput.net/pull/78)
+- **BREAKING**: Some implementations which have been properly interfaced, are reduced to internal visibility from now on. LINK HERE [#117](https://github.com/pyrocumulus/pvoutput.net/pull/117)
 
 ### Updated
 

src/PVOutput.Net/DependencyInjection/PVOutputClientOptions.cs

@@ -3,7 +3,7 @@
     /// <summary>
     /// Options used to create a PVOutputClient through Microsoft's Dependency Injection.
     /// </summary>
-    public class PVOutputClientOptions
+    public sealed class PVOutputClientOptions
     {
         /// <summary>ApiKey to use with authenticating.</summary>
         public string ApiKey { get; set; }

src/PVOutput.Net/Modules/BaseService.cs

@@ -3,7 +3,7 @@
     /// <summary>
     /// Base that all the PVOutput services derive from
     /// </summary>
-    public abstract class BaseService
+    internal abstract class BaseService
     {
         internal PVOutputClient Client { get; }
 

src/PVOutput.Net/Modules/ExtendedService.cs

@@ -12,7 +12,7 @@
 namespace PVOutput.Net.Modules
 {
     /// <inheritdoc cref="IExtendedService"/>
-    public sealed class ExtendedService : BaseService, IExtendedService
+    internal sealed class ExtendedService : BaseService, IExtendedService
     {
         internal ExtendedService(PVOutputClient client) : base(client)
         {

src/PVOutput.Net/Modules/FavouriteService.cs

@@ -10,7 +10,7 @@
 namespace PVOutput.Net.Modules
 {
     /// <inheritdoc cref="IFavouriteService"/>
-    public sealed class FavouriteService : BaseService, IFavouriteService
+    internal sealed class FavouriteService : BaseService, IFavouriteService
     {
         internal FavouriteService(PVOutputClient client) : base(client)
         {

src/PVOutput.Net/Modules/InsolationService.cs

@@ -11,7 +11,7 @@
 namespace PVOutput.Net.Modules
 {
     /// <inheritdoc cref="IInsolationService"/>
-    public sealed class InsolationService : BaseService, IInsolationService
+    internal sealed class InsolationService : BaseService, IInsolationService
     {
         internal InsolationService(PVOutputClient client) : base(client)
         {

src/PVOutput.Net/Modules/MissingService.cs

@@ -12,7 +12,7 @@
 namespace PVOutput.Net.Modules
 {
     /// <inheritdoc cref="IMissingService"/>
-    public sealed class MissingService : BaseService, IMissingService
+    internal sealed class MissingService : BaseService, IMissingService
     {
         internal MissingService(PVOutputClient client) : base(client)
         {

src/PVOutput.Net/Modules/NotificationService.cs

@@ -11,7 +11,7 @@
 namespace PVOutput.Net.Modules
 {
     /// <inheritdoc cref="INotificationService" />
-    public sealed class NotificationService : BaseService, INotificationService
+    internal sealed class NotificationService : BaseService, INotificationService
     {
         /// <summary>
         /// Alert for a new private message.

src/PVOutput.Net/Modules/OutputService.cs

@@ -13,7 +13,7 @@
 namespace PVOutput.Net.Modules
 {
     /// <inheritdoc cref="IOutputService"/>
-    public sealed class OutputService : BaseService, IOutputService
+    internal sealed class OutputService : BaseService, IOutputService
     {
         internal OutputService(PVOutputClient client) : base(client)
         {

src/PVOutput.Net/Modules/SearchService.cs

@@ -14,7 +14,7 @@
 namespace PVOutput.Net.Modules
 {
     /// <inheritdoc cref="ISearchService"/>
-    public sealed class SearchService : BaseService, ISearchService
+    internal sealed class SearchService : BaseService, ISearchService
     {
         internal SearchService(PVOutputClient client) : base(client)
         {

src/PVOutput.Net/Modules/StatisticsService.cs

@@ -12,7 +12,7 @@
 namespace PVOutput.Net.Modules
 {
     /// <inheritdoc cref="IStatisticsService"/>
-    public sealed class StatisticsService : BaseService, IStatisticsService
+    internal sealed class StatisticsService : BaseService, IStatisticsService
     {
         internal StatisticsService(PVOutputClient client) : base(client)
         {

src/PVOutput.Net/Modules/StatusService.cs

@@ -12,7 +12,7 @@
 namespace PVOutput.Net.Modules
 {
     /// <inheritdoc cref="IStatusService"/>
-    public sealed class StatusService : BaseService, IStatusService
+    internal sealed class StatusService : BaseService, IStatusService
     {
         internal StatusService(PVOutputClient client) : base(client)
         {

src/PVOutput.Net/Modules/SupplyService.cs

@@ -10,7 +10,7 @@
 namespace PVOutput.Net.Modules
 {
     /// <inheritdoc cref="ISupplyService"/>
-    public sealed class SupplyService : BaseService, ISupplyService
+    internal sealed class SupplyService : BaseService, ISupplyService
     {
         internal SupplyService(PVOutputClient client) : base(client)
         {

src/PVOutput.Net/Modules/SystemService.cs

@@ -11,7 +11,7 @@
 namespace PVOutput.Net.Modules
 {
     /// <inheritdoc cref="ISystemService"/>>
-    public sealed class SystemService : BaseService, ISystemService
+    internal sealed class SystemService : BaseService, ISystemService
     {
         internal SystemService(PVOutputClient client) : base(client)
         {

src/PVOutput.Net/Modules/TeamService.cs

@@ -10,7 +10,7 @@
 namespace PVOutput.Net.Modules
 {
     /// <inheritdoc cref="ITeamService"/>
-    public sealed class TeamService : BaseService, ITeamService
+    internal sealed class TeamService : BaseService, ITeamService
     {
         internal TeamService(PVOutputClient client) : base(client)
         {

src/PVOutput.Net/Objects/Core/CharacterDelimitedArrayStringReader.cs

@@ -7,7 +7,7 @@
 
 namespace PVOutput.Net.Objects.Core
 {
-    internal class CharacterDelimitedArrayStringReader<TObjectType> : BaseArrayStringReader<TObjectType>
+    internal sealed class CharacterDelimitedArrayStringReader<TObjectType> : BaseArrayStringReader<TObjectType>
     {
         public char Delimiter { get; }
 

src/PVOutput.Net/Objects/Core/LineDelimitedArrayStringReader.cs

@@ -7,7 +7,7 @@
 
 namespace PVOutput.Net.Objects.Core
 {
-    internal class LineDelimitedArrayStringReader<TObjectType> : BaseArrayStringReader<TObjectType>
+    internal sealed class LineDelimitedArrayStringReader<TObjectType> : BaseArrayStringReader<TObjectType>
     {
         public LineDelimitedArrayStringReader()
         {

src/PVOutput.Net/Objects/Core/LoggingEvents.cs

@@ -5,7 +5,7 @@
 
 namespace PVOutput.Net.Objects.Core
 {
-    internal class LoggingEvents
+    internal static class LoggingEvents
     {
         /*
          * Logging scope (parameter) keywords

src/PVOutput.Net/Objects/Factories/AggregatedOutputFactory.cs

@@ -4,7 +4,7 @@
 
 namespace PVOutput.Net.Objects.Factories
 {
-    internal class AggregatedOutputFactory : IArrayStringFactory<IAggregatedOutput>
+    internal sealed class AggregatedOutputFactory : IArrayStringFactory<IAggregatedOutput>
     {
         public IArrayStringReader<IAggregatedOutput> CreateArrayReader() => new CharacterDelimitedArrayStringReader<IAggregatedOutput>();
 

src/PVOutput.Net/Objects/Factories/BatchStatusPostResultFactory.cs

@@ -4,7 +4,7 @@
 
 namespace PVOutput.Net.Objects.Factories
 {
-    internal class BatchStatusPostResultFactory : IArrayStringFactory<IBatchStatusPostResult>
+    internal sealed class BatchStatusPostResultFactory : IArrayStringFactory<IBatchStatusPostResult>
     {
         public IArrayStringReader<IBatchStatusPostResult> CreateArrayReader() => new CharacterDelimitedArrayStringReader<IBatchStatusPostResult>();
 

src/PVOutput.Net/Objects/Factories/DayStatisticsFactory.cs

@@ -4,7 +4,7 @@
 
 namespace PVOutput.Net.Objects.Factories
 {
-    internal class DayStatisticsFactory : IObjectStringFactory<IDayStatistics>
+    internal sealed class DayStatisticsFactory : IObjectStringFactory<IDayStatistics>
     {
         public IObjectStringReader<IDayStatistics> CreateObjectReader() => new DayStatisticsObjectStringReader();
     }

src/PVOutput.Net/Objects/Factories/ExtendedFactory.cs

@@ -5,7 +5,7 @@
 
 namespace PVOutput.Net.Objects.Factories
 {
-    internal class ExtendedFactory : IArrayStringFactory<IExtended>
+    internal sealed class ExtendedFactory : IArrayStringFactory<IExtended>
     {
         public IArrayStringReader<IExtended> CreateArrayReader() => new CharacterDelimitedArrayStringReader<IExtended>();
 

src/PVOutput.Net/Objects/Factories/FavouriteFactory.cs

@@ -5,7 +5,7 @@
 
 namespace PVOutput.Net.Objects.Factories
 {
-    internal class FavouriteFactory : IArrayStringFactory<IFavourite>
+    internal sealed class FavouriteFactory : IArrayStringFactory<IFavourite>
     {
         public IArrayStringReader<IFavourite> CreateArrayReader() => new CharacterDelimitedArrayStringReader<IFavourite>('\n');
 

src/PVOutput.Net/Objects/Factories/InsolationFactory.cs

@@ -5,7 +5,7 @@
 
 namespace PVOutput.Net.Objects.Factories
 {
-    internal class InsolationFactory : IArrayStringFactory<IInsolation>
+    internal sealed class InsolationFactory : IArrayStringFactory<IInsolation>
     {
         public IArrayStringReader<IInsolation> CreateArrayReader() => new CharacterDelimitedArrayStringReader<IInsolation>();
 

src/PVOutput.Net/Objects/Factories/MissingFactory.cs

@@ -5,7 +5,7 @@
 
 namespace PVOutput.Net.Objects.Factories
 {
-    internal class MissingFactory : IObjectStringFactory<IMissing>
+    internal sealed class MissingFactory : IObjectStringFactory<IMissing>
     {
         public IObjectStringReader<IMissing> CreateObjectReader() => new MissingObjectStringReader();
     }

src/PVOutput.Net/Objects/Factories/OutputFactory.cs

@@ -4,7 +4,7 @@
 
 namespace PVOutput.Net.Objects.Factories
 {
-    internal class OutputFactory : IArrayStringFactory<IOutput>
+    internal sealed class OutputFactory : IArrayStringFactory<IOutput>
     {
         public IArrayStringReader<IOutput> CreateArrayReader() => new CharacterDelimitedArrayStringReader<IOutput>();
 

src/PVOutput.Net/Objects/Factories/StatisticFactory.cs

@@ -4,7 +4,7 @@
 
 namespace PVOutput.Net.Objects.Factories
 {
-    internal class StatisticFactory : IObjectStringFactory<IStatistic>
+    internal sealed class StatisticFactory : IObjectStringFactory<IStatistic>
     {
         public IObjectStringReader<IStatistic> CreateObjectReader() => new StatisticObjectStringReader();
     }

src/PVOutput.Net/Objects/Factories/StatusFactory.cs

@@ -4,7 +4,7 @@
 
 namespace PVOutput.Net.Objects.Factories
 {
-    internal class StatusFactory : IObjectStringFactory<IStatus>
+    internal sealed class StatusFactory : IObjectStringFactory<IStatus>
     {
         public IObjectStringReader<IStatus> CreateObjectReader() => new StatusObjectStringReader();
     }

src/PVOutput.Net/Objects/Factories/StatusHistoryFactory.cs

@@ -4,7 +4,7 @@
 
 namespace PVOutput.Net.Objects.Factories
 {
-    internal class StatusHistoryFactory : IArrayStringFactory<IStatusHistory>
+    internal sealed class StatusHistoryFactory : IArrayStringFactory<IStatusHistory>
     {
         public IArrayStringReader<IStatusHistory> CreateArrayReader() => new CharacterDelimitedArrayStringReader<IStatusHistory>();
 

src/PVOutput.Net/Objects/Factories/SupplyFactory.cs

@@ -4,7 +4,7 @@
 
 namespace PVOutput.Net.Objects.Factories
 {
-    internal class SupplyFactory : IArrayStringFactory<ISupply>
+    internal sealed class SupplyFactory : IArrayStringFactory<ISupply>
     {
         public IArrayStringReader<ISupply> CreateArrayReader() => new CharacterDelimitedArrayStringReader<ISupply>();
 

src/PVOutput.Net/Objects/Factories/SystemFactory.cs

@@ -4,7 +4,7 @@
 
 namespace PVOutput.Net.Objects.Factories
 {
-    internal class SystemFactory : IObjectStringFactory<ISystem>
+    internal sealed class SystemFactory : IObjectStringFactory<ISystem>
     {
         public IObjectStringReader<ISystem> CreateObjectReader() => new SystemObjectStringReader();
     }

src/PVOutput.Net/Objects/Factories/SystemSearchResultFactory.cs

@@ -5,7 +5,7 @@
 
 namespace PVOutput.Net.Objects.Factories
 {
-    internal class SystemSearchResultFactory : IArrayStringFactory<ISystemSearchResult>
+    internal sealed class SystemSearchResultFactory : IArrayStringFactory<ISystemSearchResult>
     {
         public IArrayStringReader<ISystemSearchResult> CreateArrayReader() => new LineDelimitedArrayStringReader<ISystemSearchResult>();
 

src/PVOutput.Net/Objects/Factories/TeamFactory.cs

@@ -5,7 +5,7 @@
 
 namespace PVOutput.Net.Objects.Factories
 {
-    internal class TeamFactory : IObjectStringFactory<ITeam>
+    internal sealed class TeamFactory : IObjectStringFactory<ITeam>
     {
         public IObjectStringReader<ITeam> CreateObjectReader() => new TeamObjectStringReader();
     }

src/PVOutput.Net/Objects/Factories/TeamOutputFactory.cs

@@ -4,7 +4,7 @@
 
 namespace PVOutput.Net.Objects.Factories
 {
-    internal class TeamOutputFactory : IArrayStringFactory<ITeamOutput>
+    internal sealed class TeamOutputFactory : IArrayStringFactory<ITeamOutput>
     {
         public IArrayStringReader<ITeamOutput> CreateArrayReader() => new CharacterDelimitedArrayStringReader<ITeamOutput>();
 

src/PVOutput.Net/Objects/Modules/BatchNetStatusPost.cs

@@ -6,7 +6,7 @@
 
 namespace PVOutput.Net.Objects.Modules
 {
-    internal class BatchNetStatusPost : IBatchNetStatusPost
+    internal sealed class BatchNetStatusPost : IBatchNetStatusPost
     {
         public DateTime Timestamp { get; set; }
         public int? PowerExported { get; set; }

src/PVOutput.Net/Objects/Modules/Implementations/AggregatedOutput.cs

@@ -1,8 +1,8 @@
-using System;
+using System;
 
 namespace PVOutput.Net.Objects.Modules.Implementations
 {
-    internal class AggregatedOutput : IAggregatedOutput
+    internal sealed class AggregatedOutput : IAggregatedOutput
     {
         public DateTime AggregatedDate { get; set; }
         public int Outputs { get; set; }

src/PVOutput.Net/Objects/Modules/Implementations/DayStatistics.cs

@@ -2,7 +2,7 @@
 
 namespace PVOutput.Net.Objects.Modules.Implementations
 {
-    internal class DayStatistics : IDayStatistics
+    internal sealed class DayStatistics : IDayStatistics
     {
         public int EnergyGeneration { get; set; }
         public int PowerGeneration { get; set; }

src/PVOutput.Net/Objects/Modules/Implementations/Extended.cs

@@ -4,7 +4,7 @@
 
 namespace PVOutput.Net.Objects.Modules.Implementations
 {
-    internal class Extended : IExtended
+    internal sealed class Extended : IExtended
     {
         public DateTime ExtendedDate { get; set; }
         public decimal? ExtendedValue1 { get; set; }

src/PVOutput.Net/Objects/Modules/Implementations/ExtendedDataDefinition.cs

@@ -5,7 +5,7 @@
 
 namespace PVOutput.Net.Objects.Modules.Implementations
 {
-    internal class ExtendedDataDefinition : IExtendedDataDefinition
+    internal sealed class ExtendedDataDefinition : IExtendedDataDefinition
     {
         public ExtendedDataIndex Index { get; set; }
         public string Label { get; set; }

src/PVOutput.Net/Objects/Modules/Implementations/Favourite.cs

@@ -5,7 +5,7 @@
 
 namespace PVOutput.Net.Objects.Modules.Implementations
 {
-    internal class Favourite : IFavourite
+    internal sealed class Favourite : IFavourite
     {
         public int SystemId { get; set; }
         public string SystemName { get; set; }

src/PVOutput.Net/Objects/Modules/Implementations/Insolation.cs

@@ -4,7 +4,7 @@
 
 namespace PVOutput.Net.Objects.Modules.Implementations
 {
-    internal class Insolation : IInsolation
+    internal sealed class Insolation : IInsolation
     {
         public TimeSpan Time { get; set; }
         public int Power { get; set; }

src/PVOutput.Net/Objects/Modules/Implementations/Missing.cs

@@ -1,9 +1,9 @@
-using System;
+using System;
 using System.Collections.Generic;
 
 namespace PVOutput.Net.Objects.Modules.Implementations
 {
-    internal class Missing : IMissing
+    internal sealed class Missing : IMissing
     {
         public IEnumerable<DateTime> Dates { get; set; }
     }

src/PVOutput.Net/Objects/Modules/Implementations/Output.cs

@@ -3,7 +3,7 @@
 
 namespace PVOutput.Net.Objects.Modules.Implementations
 {
-    internal class Output : IOutput
+    internal sealed class Output : IOutput
     {
         public DateTime OutputDate { get; set; }
         public int EnergyGenerated { get; set; }