Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease visibility of public types #71

Closed
pyrocumulus opened this issue Jun 1, 2021 · 0 comments · Fixed by #117
Closed

Decrease visibility of public types #71

pyrocumulus opened this issue Jun 1, 2021 · 0 comments · Fixed by #117
Labels
api breaking change This issue or pull request will result in a breaking change code quality Improves unit testing, code coverage and/or reduces dead code
Milestone
1.0.0

Comments

@pyrocumulus
Copy link
Owner

As most of the library is now covered by interfaces to help users with unit testing, it makes sense to decrease the visibility of the underlying actual implementations. It doesn't make sense to have the interfaces public as well as the implementations. The latter can go back to internal. This is especially true for all the modules.

It's also worth looking at the rest of the public facing types regarding this point.
@pyrocumulus pyrocumulus added api breaking change This issue or pull request will result in a breaking change code quality Improves unit testing, code coverage and/or reduces dead code labels Jun 1, 2021
@pyrocumulus pyrocumulus added this to the 1.0.0 milestone Jun 1, 2021
pyrocumulus added a commit that referenced this issue Mar 17, 2022
@pyrocumulus
Reduced public visibility of interfaced implementations
02a82b9 
Also sealed most of the internal classes where applicable
Closes #71
@pyrocumulus pyrocumulus mentioned this issue Mar 17, 2022
Merged
pyrocumulus added a commit that referenced this issue Mar 17, 2022
@pyrocumulus
Reduced public visibility of interfaced implementations (#117)
86d2514 
* Reduced public visibility of interfaced implementations
* Also sealed most of the internal classes where applicable

Closes #71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api breaking change This issue or pull request will result in a breaking change code quality Improves unit testing, code coverage and/or reduces dead code
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Reduced public visibility of interfaced implementations pyrocumulus/pvoutput.net
1 participant
@pyrocumulus