-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTM after next push] fix: linear continuous multiphase continuity #857
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #857 +/- ##
==========================================
+ Coverage 78.25% 78.30% +0.04%
==========================================
Files 140 141 +1
Lines 16230 16278 +48
==========================================
+ Hits 12701 12746 +45
- Misses 3529 3532 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Ipuch)
bioptim/limits/phase_transtion_builder.py
line 6 at r2 (raw file):
class PhaseTransitionBuilder:
Factory?
bioptim/limits/phase_transtion_builder.py
line 54 at r2 (raw file):
weight=None, ) for i in range(self.ocp.n_phases - 1)
What is that second for for?
tests/shard1/test_continuity_linear_continuous.py
line 28 at r2 (raw file):
solution = ocp.solve(Solver.IPOPT(_max_iter=5)) print(solution.detailed_cost)
do not print?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 6 files reviewed, 3 unresolved discussions (waiting on @pariterre)
tests/shard1/test_continuity_linear_continuous.py
line 28 at r2 (raw file):
Previously, pariterre (Pariterre) wrote…
do not print?
Done.
bioptim/limits/phase_transtion_builder.py
line 6 at r2 (raw file):
Previously, pariterre (Pariterre) wrote…
Factory?
Done.
bioptim/limits/phase_transtion_builder.py
line 54 at r2 (raw file):
Previously, pariterre (Pariterre) wrote…
What is that second for for?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)
All Submissions:
New Feature Submissions:
black . -l120 --exclude "external/*"
)?Changes to Core Features:
This change is