Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM when tested] Added a multi-node constraint for the total duration of the movement #782

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

EveCharbie
Copy link
Collaborator

@EveCharbie EveCharbie commented Oct 20, 2023

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
bioptim/limits/constraints.py 51.40% <100.00%> (+2.64%) ⬆️
bioptim/limits/multinode_constraint.py 96.15% <100.00%> (+0.07%) ⬆️
bioptim/limits/penalty.py 83.53% <ø> (+0.16%) ⬆️
bioptim/optimization/non_linear_program.py 90.84% <100.00%> (+0.37%) ⬆️
bioptim/limits/multinode_penalty.py 62.20% <90.00%> (+3.54%) ⬆️
bioptim/limits/penalty_controller.py 88.57% <88.88%> (+0.02%) ⬆️

... and 8 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@EveCharbie EveCharbie changed the title Added a multi-node constraint for the total duration of the movement [RTR] Added a multi-node constraint for the total duration of the movement Oct 20, 2023
pariterre
pariterre previously approved these changes Oct 23, 2023
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)

@pariterre
Copy link
Member

Waiting for a little test and then merging!

@pariterre pariterre changed the title [RTR] Added a multi-node constraint for the total duration of the movement [RTM when tested] Added a multi-node constraint for the total duration of the movement Oct 26, 2023
@EveCharbie
Copy link
Collaborator Author

@pariterre can be merged :)
Just check first because I fixed a bunch of other bugs while I was at it.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)

@pariterre pariterre merged commit 928b778 into pyomeca:master Oct 27, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants