-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec and test #70
Spec and test #70
Conversation
Including introducing new testing classes to directly test for promises made on the base class. In general, I want to head this direction in this PR: be as explicit as possible about the promises the classes make, and then test each of the promises as directly as possible.
Including testing each of the run boolean flags
Being running stops us from being ready, so we don't get all the way to the runtime error but stop at the readiness check
Pull Request Test Coverage Report for Build 6832421987
💛 - Coveralls |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
And move a bit more into the abstract node tests
Using a format of "promises" the class makes about its behaviour
Some of the tests are pulled (and often modified) from child classes
For symmetry with Function
For disabling multiple IO channels
Don't allow the manual reassignment of the parent attribute, but always pass through add or remove (after instantiation -- at instantiation we can handle it)
This leans more heavily on the documentation of `attributes` and `methods` as well as `examples` in child classes to highlight the nitty-gritty of implementation, and makes the rest of the docstring shorter and more abstract (but hopefully also clearer)
Which are no longer necessary as long as macros are a walled garden and workflows are parent-most
It should "technically" be public in that it gets accessed from outside its own instance, but it's just part of the plumbing and I don't want it popping up on users' tab-completion lists
The notebooks failure is actually the same problem that is causing the
My knee-jerk suspicion is that materials project has again inserted a direct dependency into their code without including that dependency directly and the API has gotten out of sync with what conda is actually installing, although just because that happened before doesn't mean it's for sure what's happening now. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
But leave it commented out, since the docs are still empty. For the main page I expect this, but I still don't get why the API docs are giving me a 404
Update the documentation and testing.
Channel
IO
Node
Function
Composite
Macro
Workflow
__init__
quickstart.ipynb
Closes #61
Closes #62