Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec and test #70

Merged
merged 41 commits into from
Nov 11, 2023
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
d0f7704
Update channel docs and test to them
liamhuber Nov 6, 2023
4f76dc5
Never allow input data updates while the parent node is running
liamhuber Nov 6, 2023
a9381c8
Update Node docs and make tests for the base class
liamhuber Nov 6, 2023
f138999
Draft module-level overview for API docs/use in readme
liamhuber Nov 6, 2023
70f0d98
Test single point of import
liamhuber Nov 6, 2023
35b5c0e
:bug: fix the expected error to be raised
liamhuber Nov 6, 2023
300ad1c
Update IO docstring
liamhuber Nov 6, 2023
5f567f0
Update Function docstring
liamhuber Nov 6, 2023
7fd250e
Update function tests
liamhuber Nov 6, 2023
37c2262
Test the call aliases
liamhuber Nov 6, 2023
dbddd14
Update Composite docs
liamhuber Nov 10, 2023
7739aeb
Improve working directory test
liamhuber Nov 10, 2023
aa01945
Update composite promises
liamhuber Nov 10, 2023
27ce1d5
:bug: actually iterate over child nodes
liamhuber Nov 10, 2023
fff90cf
Pull up the IO rebuild check after node replacement
liamhuber Nov 10, 2023
a02adee
Test the promises made in Composite directly
liamhuber Nov 10, 2023
bcce14d
Make Macro's graph_creator available as a class method
liamhuber Nov 10, 2023
7d9238e
Use setUp
liamhuber Nov 10, 2023
6e88ef3
Define and test Macro promises
liamhuber Nov 10, 2023
8a31793
Make and test Workflow promises
liamhuber Nov 10, 2023
53557cf
:bug: handle bidict None duplication
liamhuber Nov 11, 2023
2eda950
:bug: check for instance type
liamhuber Nov 11, 2023
811fb79
Apply de-duplication of None values to both I and O
liamhuber Nov 11, 2023
6eab6ae
:bug: make sure the map is persistent
liamhuber Nov 11, 2023
0577034
Pull the bijectivity tests up to Composite
liamhuber Nov 11, 2023
2554682
Reformat Function as promises
liamhuber Nov 11, 2023
29a4b29
Finish parent promises
liamhuber Nov 11, 2023
414d1c5
Update node docs to the "promises" format
liamhuber Nov 11, 2023
8f2b40c
Reorder node tests to better match the order of the promises
liamhuber Nov 11, 2023
cb47ed2
Remove redundant topology tools
liamhuber Nov 11, 2023
d674887
Make method private
liamhuber Nov 11, 2023
ab2435a
Format black
pyiron-runner Nov 11, 2023
75881f7
Add a short sleep
liamhuber Nov 11, 2023
9a47ca9
Update example notebook
liamhuber Nov 11, 2023
724bce7
Rename and re-run the example notebook
liamhuber Nov 11, 2023
290a282
Add quickstart notebook
liamhuber Nov 11, 2023
2f2c79b
Add badges to readme
liamhuber Nov 11, 2023
fc6dcd0
Update overview
liamhuber Nov 11, 2023
3b65a35
Add tailing readme sections
liamhuber Nov 11, 2023
4538443
Update readme code example
liamhuber Nov 11, 2023
4ec4d72
Update the docs badge
liamhuber Nov 11, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyiron_workflow/channels.py
Original file line number Diff line number Diff line change
@@ -504,7 +504,7 @@ def __call__(self) -> None:
def generic_type(self) -> type[Channel]:
return SignalChannel

def connect_output_signal(self, signal: OutputSignal):
def _connect_output_signal(self, signal: OutputSignal):
self.connect(signal)


@@ -552,5 +552,5 @@ def __str__(self):
)

def __gt__(self, other: InputSignal | Node):
other.connect_output_signal(self)
other._connect_output_signal(self)
return True
4 changes: 2 additions & 2 deletions pyiron_workflow/node.py
Original file line number Diff line number Diff line change
@@ -630,14 +630,14 @@ def __str__(self):
f"{str(self.signals)}"
)

def connect_output_signal(self, signal: OutputSignal):
def _connect_output_signal(self, signal: OutputSignal):
self.signals.input.run.connect(signal)

def __gt__(self, other: InputSignal | Node):
"""
Allows users to connect run and ran signals like: `first_node > second_node`.
"""
other.connect_output_signal(self.signals.output.ran)
other._connect_output_signal(self.signals.output.ran)
return True

def copy_io(