-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SUNDIALS version + test JaxSolver on all Python versions #2958
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #2958 +/- ##
===========================================
- Coverage 99.71% 96.47% -3.24%
===========================================
Files 273 273
Lines 19002 19002
===========================================
- Hits 18947 18332 -615
- Misses 55 670 +615 ☔ View full report in Codecov by Sentry. |
@@ -22,6 +22,7 @@ deps = | |||
|
|||
commands = | |||
tests-!windows-!mac: sh -c "pybamm_install_jax" # install jax, jaxlib for ubuntu | |||
unit-!windows-!mac: sh -c "pybamm_install_jax" # install jax, jaxlib for ubuntu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ensures that every jax
related thing in PyBaMM is unit tested on all Python versions and not just 3.9
(during coverage).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks @Saransh-cpp
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #2953
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
$ python run-tests.py --doctest
You can run unit and doctests together at once, using
$ python run-tests.py --quick
.Further checks: