Merge pull request #2958 from Saransh-cpp/fix-jax-odes

Update SUNDIALS version + test JaxSolver on all Python versions
pybamm-team · May 17, 2023 · 3d20678 · 3d20678
2 parents 137ae23 + a8c2dd3
commit 3d20678
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 1 deletion.
diff --git a/.gitignore b/.gitignore
@@ -2,6 +2,7 @@
 *.pdf
 *.tmp
 *.png
+*.gif
 /local/
 *.DS_Store
 *.mat

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,10 +7,12 @@
 
 ## Optimizations
 
+- Test `JaxSolver`'s compatibility with Python `3.8`, `3.9`, `3.10`, and `3.11`  ([#2958](https://github.com/pybamm-team/PyBaMM/pull/2958))
 - Update Jax (0.4.8) and JaxLib (0.4.7) compatibility ([#2927](https://github.com/pybamm-team/PyBaMM/pull/2927))
 
 ## Bug fixes
 
+- Fix `pybamm_install_odes` and update the required SUNDIALS version ([#2958](https://github.com/pybamm-team/PyBaMM/pull/2958))
 - Remove brew install for Mac from the recommended developer installation options for SUNDIALS ([#2925](https://github.com/pybamm-team/PyBaMM/pull/2925))
 
 # [v23.4.1](https://github.com/pybamm-team/PyBaMM/tree/v23.4) - 2023-05-01

diff --git a/pybamm/install_odes.py b/pybamm/install_odes.py
@@ -33,7 +33,7 @@ def download_extract_library(url, directory):
 def install_sundials(download_dir, install_dir):
     # Download the SUNDIALS library and compile it.
     logger = logging.getLogger("scikits.odes setup")
-    sundials_version = "5.1.0"
+    sundials_version = "6.5.0"
 
     try:
         subprocess.run(["cmake", "--version"])

diff --git a/tox.ini b/tox.ini
@@ -22,6 +22,7 @@ deps =
 
 commands =
      tests-!windows-!mac: sh -c "pybamm_install_jax"  # install jax, jaxlib for ubuntu
+     unit-!windows-!mac: sh -c "pybamm_install_jax"  # install jax, jaxlib for ubuntu
      tests: python run-tests.py --all
      unit: python run-tests.py --unit
      integration: python run-tests.py --integration
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,7 @@ @@
     *.pdf
     *.tmp
     *.png
+    *.gif
     /local/
     *.DS_Store
     *.mat
@@ Expand Down @@