Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SUNDIALS version + test JaxSolver on all Python versions #2958

Merged
merged 5 commits into from
May 17, 2023
Merged

Update SUNDIALS version + test JaxSolver on all Python versions #2958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e50145f
Update SUNDIALS version + test JaxSolver on all Python versions
Saransh-cpp May 16, 2023
9c60d76
Update CHANGELOG
Saransh-cpp May 16, 2023
0151900
Fix jax installation
Saransh-cpp May 16, 2023
ee35936
Ignore gifs in tests
Saransh-cpp May 16, 2023
a8c2dd3
Install jax explicitly in testenv:coverage
Saransh-cpp May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
*.pdf
*.tmp
*.png
*.gif
/local/
*.DS_Store
*.mat
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@

## Optimizations

- Test `JaxSolver`'s compatibility with Python `3.8`, `3.9`, `3.10`, and `3.11` ([#2958](https://github.com/pybamm-team/PyBaMM/pull/2958))
- Update Jax (0.4.8) and JaxLib (0.4.7) compatibility ([#2927](https://github.com/pybamm-team/PyBaMM/pull/2927))

## Bug fixes

- Fix `pybamm_install_odes` and update the required SUNDIALS version ([#2958](https://github.com/pybamm-team/PyBaMM/pull/2958))
- Remove brew install for Mac from the recommended developer installation options for SUNDIALS ([#2925](https://github.com/pybamm-team/PyBaMM/pull/2925))

# [v23.4.1](https://github.com/pybamm-team/PyBaMM/tree/v23.4) - 2023-05-01
Expand Down
2 changes: 1 addition & 1 deletion pybamm/install_odes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def download_extract_library(url, directory):
def install_sundials(download_dir, install_dir):
# Download the SUNDIALS library and compile it.
logger = logging.getLogger("scikits.odes setup")
sundials_version = "5.1.0"
sundials_version = "6.5.0"

try:
subprocess.run(["cmake", "--version"])
Expand Down
1 change: 1 addition & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ deps =

commands =
tests-!windows-!mac: sh -c "pybamm_install_jax" # install jax, jaxlib for ubuntu
unit-!windows-!mac: sh -c "pybamm_install_jax" # install jax, jaxlib for ubuntu
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensures that every jax related thing in PyBaMM is unit tested on all Python versions and not just 3.9 (during coverage).

tests: python run-tests.py --all
unit: python run-tests.py --unit
integration: python run-tests.py --integration
Expand Down